Problem/Motivation

PHP 8.1, Drupal 9.3.2 returns

Deprecated function: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in _fontawesome_unparse_url() (line 160 of modules/contrib/fontawesome/fontawesome.module).
CommentFileSizeAuthor
#4 strlen_null_deprecation-3258575-4.patch1.1 KBdaniel.moberly

Issue fork fontawesome-3258575

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

VladimirAus created an issue. See original summary.

VladimirAus opened merge request !6

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
CreditAttribution: vladimiraus at Tomato Elephant Studio for DrupalSouth commented
Status: Active » Needs review
daniel.moberly’s picture

daniel.moberly CreditAttribution: daniel.moberly commented
StatusFileSize
new strlen_null_deprecation-3258575-4.patch1.1 KB

I think this is significantly simplified by just changing the parse function as attached

j-barnes’s picture

j-barnes CreditAttribution: j-barnes as a volunteer commented

@daniel.moberly

Tested and confirmed working. I think changing the parse function is definitely the way to go.

j-barnes’s picture

j-barnes CreditAttribution: j-barnes as a volunteer commented
Status: Needs review » Reviewed & tested by the community

  • Daniel.Moberly committed ea6cdf3 on 8.x-2.x 
    Issue #3258575 by VladimirAus, Daniel.Moberly: Deprecated function:...
daniel.moberly’s picture

daniel.moberly CreditAttribution: daniel.moberly commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
CreditAttribution: vladimiraus at Tomato Elephant Studio for DrupalSouth commented

W00t! That was quick!
Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

willabby’s picture

willabby CreditAttribution: willabby commented

I encountered this issue when i updated, but i think it was related to:
https://www.drupal.org/project/drupal/issues/3267535