Problem/Motivation

Drupal 10.5.x/11.2.x includes an updated version of CKEditor.

This causes an error in the console log:
Uncaught TypeError: Cannot read properties of undefined (reading 'check')

Steps to reproduce

  • Update drupal to 10.5.x or 11.x
  • Attempt to load a textarea using CKeditor

Proposed resolution

Update icon compatibility per https://www.drupal.org/node/3528806

Similar to https://www.drupal.org/project/ckeditor_media_resize/issues/3531299, removing icons from the Javascript has resolved the error.

CommentFileSizeAuthor
#9 Afterpatch.png84.18 KBsaman malik
#7 3534953_after patch.png30.35 KBroshanibhangale

Issue fork footnotes-3534953

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

karengrey created an issue. See original summary.

karengrey opened merge request !87

karengrey’s picture

karengrey commented

Appreciate this is for version 3.x and not actively supported alongside 4.x
Have created a MR so those still stuck on 3.x can patch and resolve the issue.
Thanks!

karengrey’s picture

karengrey commented
Version: 3.1.0 » 3.1.x-dev
karengrey’s picture

karengrey commented
Status: Active » Needs review

For simplicity, I have removed the use of icons for save and cancel, and changed to be text buttons instead.

jiong_ye’s picture

jiong_ye commented

I am on core 10.5.1 and 3.1.0. The patch is failing to apply for me.

Edit: forgot to switch to dev branch

roshanibhangale’s picture

roshanibhangale commented
StatusFileSize
new 3534953_after patch.png30.35 KB

Hi

I have tested this on drupal 11.x and followed the below steps:

Steps to reproduce

  • Update drupal to 10.5.x or 11.x
  • Attempt to load a textarea using CKeditor

After applying patch successfully, observed that able to update the textarea with CKEditor and icons compatibility.

Hence this can be moved to RTBC+1. Attaching the screenshot for the reference

Keeping the ticekt in the Needs review for code review.

venutip’s picture

venutip commented

Thanks so much for this patch. Confirmed working with 10.5.5.

saman malik’s picture

saman malik commented
StatusFileSize
new Afterpatch.png84.18 KB

I have tested this on drupal 11.x and followed the below steps:
Steps to reproduce

  1. Update drupal to 10.5.x or 11.x
  2. Attempt to load a textarea using CKeditor
  3. After applying patch successfully, observed that able to update the textarea with CKEditor and icons compatibility.

    4. Hence this can be moved to RTBC+1. Attaching the screenshot for the reference