Problem/Motivation

Latest release (2.0.0-beta1) errors out after installing on Drupal 8.

Upon installation, you get the following error:

TypeError: Argument 1 passed to Drupal\force_password_change\EventSubscriber\ForcePasswordChangeEventSubscriber::checkForPasswordForce() must be an instance of Symfony\Component\HttpKernel\Event\RequestEvent, instance of Symfony\Component\HttpKernel\Event\GetResponseEvent given in Drupal\force_password_change\EventSubscriber\ForcePasswordChangeEventSubscriber->checkForPasswordForce() (line 88 of modules/contrib/force_password_change/src/EventSubscriber/ForcePasswordChangeEventSubscriber.php).

Symfony 3 still has the GetResponseEvent. Symfony 4 contains the RequestEvent.

Steps to reproduce

  1. Install drupal/core-recommended 8.9.16 wich has symfony/http-kernel v3.4.44 hard dependency.
  2. Install the module.

Proposed resolution

Don't mark release as D8 compatible.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 beforepatch2.png130.55 KBlaisbonafe
#5 afterpatch.png84.19 KBlaisbonafe
#4 3222291-4.patch1.15 KBlarisse
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Stefdewa created an issue. See original summary.

Stefdewa’s picture

Stefdewa CreditAttribution: Stefdewa at Calibrate commented
Issue summary: View changes
caspervoogt’s picture

caspervoogt CreditAttribution: caspervoogt commented

I agree; I just ran into this too.

larisse’s picture

larisse CreditAttribution: larisse at CI&T commented
Status: Active » Needs review
FileSize
3222291-4.patch1.15 KB

Hi! I create a patch for this issue.

laisbonafe’s picture

laisbonafe CreditAttribution: laisbonafe at CI&T commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
afterpatch.png84.19 KB
beforepatch2.png130.55 KB

Hi, I tested and the patch of comment #4 fixed the issue.

error to install before patch:

everything ok to install after patch: (ignore the mesage for update core to 8.9.18)

laisbonafe’s picture

laisbonafe CreditAttribution: laisbonafe at CI&T commented
Issue summary: View changes

  • larisse committed e07f4fc on 2.0.x 
    Issue #3222291 by larisse, laisbonafe: Branch 2.0.x not compatible with...
larisse’s picture

larisse CreditAttribution: larisse at CI&T commented
Status: Reviewed & tested by the community » Fixed

Thank you @laisbonafe

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jds1’s picture

jds1
he/they
Location Hudson Valley, NY
CreditAttribution: jds1 commented

Patch applies cleanly and works. Can we please get this into a release? Lots of D8 sites are probably upgrading after seeing this module on an Upgrade Status report and it would be helpful to have this working without a patch. Thanks!