Hi,

I found a couple of small commenting standards issue when running coder on the Google Analytics module. The attached patch fixes these. Though the patch was made against the DRUPAL-6--1 branch, it should also apply cleanly to the DRUPAL-6--2 branch too.

Also, as a side note, you should consider updating your simple tests to work with the newer SimpleTest API, for example, your tests should extend DrupalWebTestCase rather than DrupalTestCase. See the SimpleTest module page for links to the updated docs.

Cheers,
Stella

CommentFileSizeAuthor
#5 googleanalytics_comment_2.patch674 bytesstella
#1 google_analytics_comments.patch652 bytesstella
google_analytics_comments.patch1.27 KBstella
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stella’s picture

stella CreditAttribution: stella commented
FileSize
google_analytics_comments.patch652 bytes

Re-rolled the patch with some formatting corrected. Also removed the @file comment block for the test file from my last patch since according to current standards at http://groups.drupal.org/node/7731 no @file comments should be used for test files, though this may change in the future.

hass’s picture

hass CreditAttribution: hass commented

Do you know how to update simpletest? Is it only the above name change? If not - are you able to upgrade?

stella’s picture

stella CreditAttribution: stella commented

No, I'm afraid I don't really. I'm pretty sure that get_info() was renamed to getInfo(), but I don't know what the other changes were. The changes came about because the new version doesn't use the external simpletest library. The google analytics code only uses a small number of simpletest functions so you could check the api functions listed at http://drupal.org/node/30023 and see if any have changed. Sorry I can't give you any more info.

Cheers,
Stella

hass’s picture

hass CreditAttribution: hass commented
Status: Needs review » Fixed

We need to find someone who can update the simpletest stuff... :-)

stella’s picture

stella CreditAttribution: stella commented
Status: Fixed » Needs review
FileSize
googleanalytics_comment_2.patch674 bytes

Commenting standards for test files have changed (http://groups.drupal.org/node/7731), so here's a patch that adds in the @file block to the test file that I had in my original patch.

Cheers,
Stella

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community

Trivial patch, RTBC.

hass’s picture

hass CreditAttribution: hass commented
Status: Reviewed & tested by the community » Fixed
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.