Problem/Motivation

PHP deprecation notice:

PHP Deprecated:  a:5:{s:11:"deprecation";s:78:"explode(): Passing null to parameter #2 ($string) of type string is deprecated";s:5:"class";s:65:"Drupal\Tests\google_analytics\Functional\GoogleAnalyticsBasicTest";s:6:"method";s:31:"testGoogleAnalyticsTrackingCode";s:15:"triggering_file";s:130:"/home/runner/work/acquia_cms/orca-build/docroot/modules/contrib/google_analytics/tests/src/Functional/GoogleAnalyticsBasicTest.php";s:11:"files_stack";a:7:{i:0;s:130:"/home/runner/work/acquia_cms/orca-build/docroot/modules/contrib/google_analytics/tests/src/Functional/GoogleAnalyticsBasicTest.php";i:1;s:77:"/home/runner/work/acquia_cms/orca-build/docroot/sites/simpletest/TestCase.php";i:2;s:77:"/home/runner/work/acquia_cms/orca-build/docroot/sites/simpletest/TestCase.php";i:3;s:91:"/home/runner/work/acquia_cms/orca-build/vendor/phpunit/phpunit/src/Framework/TestResult.php";i:4;s:77:"/home/runner/work/acquia_cms/orca-build/docroot/sites/simpletest/TestCase.php";i:5;s:19:"Standard input code";i:6;s:19:"Standard input code";}} in /home/runner/work/acquia_cms/orca-build/vendor/symfony/phpunit-bridge/Legacy/SymfonyTestsListenerTrait.php on line 284

Issue fork google_analytics-3357831

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vishalkhode created an issue. See original summary.

sakthi_dev made their first commit to this issue’s fork.

sakthi_dev opened merge request !30

sakthi_dev’s picture

sakthi_dev CreditAttribution: sakthi_dev at Specbee for Drupal India Association commented
Status: Active » Needs review

Please review.

Rajeshreeputra’s picture

Rajeshreeputra
Location Pune
CreditAttribution: Rajeshreeputra as a volunteer and at Acquia, Shivswarajya Inc. commented
Status: Needs review » Reviewed & tested by the community

Changes looks good, tests passing, moving ahead.

MegaKeegMan’s picture

MegaKeegMan CreditAttribution: MegaKeegMan at Agaric for Drutopia, Portside commented

I can confirm that the issue fork also worked for me. If any maintainers are around, this appears safe to merge

rymcveigh’s picture

rymcveigh
he/him/his
CreditAttribution: rymcveigh at Morris Animal Foundation commented

This issue fork worked for me as well.

Ariun’s picture

Ariun CreditAttribution: Ariun at CTAC for CTAC commented

This changes works for me too. I would say that it is good to merge.