According to Drupal standards, modules should include dependencies in the .info.yml file.
Dependencies should be namespaced in the format {project}:{module}, where {project} is the project name as it appears in the Drupal.org URL (e.g. drupal.org/project/views) and {module} is the module's machine name.
https://www.drupal.org/docs/8/creating-custom-modules/let-drupal-8-know-...
Patch to follow, thanks!

CommentFileSizeAuthor
#2 grassroot_interests-info-3018388-2.patch301 bytesalonaoneill
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alonaoneill created an issue. See original summary.

alonaoneill’s picture

alonaoneill CreditAttribution: alonaoneill at Hook 42 commented
Assigned: alonaoneill » Unassigned
Status: Active » Needs review
FileSize
grassroot_interests-info-3018388-2.patch301 bytes

I uploaded a patch that fixs dependency namespacing in the .info.yml file.
Thanks!

Status: Needs review » Needs work

The last submitted patch, 2: grassroot_interests-info-3018388-2.patch, failed testing. View results

alonaoneill’s picture

alonaoneill CreditAttribution: alonaoneill at Hook 42 commented
Status: Needs work » Needs review
Willtg’s picture

Willtg CreditAttribution: Willtg at Hook 42 commented
Status: Needs review » Reviewed & tested by the community

Code looks good. The dependency name-spacing aligns with Drupal documentation standards. Marking as RTBC Thank you for working on the module!

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar at QED42 commented
Issue tags: +GCWIndia2020, +punedrupalgroup, +ContributionWeekend2020

Adding Tags

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
CreditAttribution: rahul.shinde at DevsAdda, Axelerant for Drupal India Association, HighWire Press, Inc commented
Status: Reviewed & tested by the community » Fixed
rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
CreditAttribution: rahul.shinde at DevsAdda, Axelerant for Drupal India Association, HighWire Press, Inc commented
Status: Fixed » Closed (fixed)