Problem/Motivation

The VariationCache module is marked as 'Unsupported' as of 8.x-1.5. However, the module cannot be uninstalled as it is listed in the info.yml file as a dependency.

Steps to reproduce

drush pmu variationcache

Proposed resolution

Allow uninstallation of variationcache

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#10 3421610-10-do-not-test.patch3.22 KBrecrit
#9 3421610-9-do-not-test.patch3.16 KBrecrit
#8 3421610-8-do-not-test.patch2.91 KBchewi3
#7 3421610-7-do-not-test.patch2.83 KBchewi3
#6 3421610-6-do-not-test.patch1.09 KBnils.destoop
#5 3421610-5.patch1.01 KBnils.destoop
#4 3421610-4-do-not-test.patch344 bytesidebr
#2 3421610-2.patch256 bytesidebr

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr CreditAttribution: idebr at iO commented
Status: Active » Needs review
StatusFileSize
new 3421610-2.patch256 bytes

Attached patch removes variationcache from the group.info.yml so the module can be uninstalled.

idebr’s picture

idebr CreditAttribution: idebr at iO commented
Related issues: +#3416620: Clarify plans around future Group releases so VC users know when to uninstall
idebr’s picture

idebr CreditAttribution: idebr at iO commented
StatusFileSize
new 3421610-4-do-not-test.patch344 bytes

Additional patch that applies against 8.x-1.6 with release packaging information.

nils.destoop’s picture

nils.destoop CreditAttribution: nils.destoop as a volunteer and at iO commented
StatusFileSize
new 3421610-5.patch1.01 KB

An updated patch as the references to variationcache needs to be replaced with the core version.

nils.destoop’s picture

nils.destoop CreditAttribution: nils.destoop as a volunteer and at iO commented
StatusFileSize
new 3421610-6-do-not-test.patch1.09 KB

And a version with packing info

chewi3’s picture

chewi3 CreditAttribution: chewi3 commented
StatusFileSize
new 3421610-7-do-not-test.patch2.83 KB

The latest patch still causes type errors. I extended the latest patch to also update references in ChainGroupPermissionCalculator.

chewi3’s picture

chewi3 CreditAttribution: chewi3 commented
StatusFileSize
new 3421610-8-do-not-test.patch2.91 KB

Now also with added packaging info

recrit’s picture

recrit CreditAttribution: recrit at Phase2 commented
StatusFileSize
new 3421610-9-do-not-test.patch3.16 KB

the attached patch also removes the dependency from composer.json. This patch is for 8.x-1.6 with the package info.

recrit’s picture

recrit CreditAttribution: recrit at Phase2 commented
StatusFileSize
new 3421610-10-do-not-test.patch3.22 KB

ignore 3421610-9-do-not-test.patch, i left a comman in the composer.json.
the attached patch also removes the dependency from composer.json. This patch is for 8.x-1.6 with the package info.

recrit’s picture

recrit CreditAttribution: recrit at Phase2 commented

it appears that composer just ignores any patched changes to the composer so you may still need to add the following to your project's composer.json in order to remove the "drupal/variationcache" dependency:

    "replace": {
      "drupal/variationcache": "*"
    },