We have a taxonomy term with this structure:

Term A
-- Child A1
-- Child A2
Term B
-- Child B1
-- Child B2

If we do GET /api/taxonomy_term/my_vocabulary?_format=api_json

Child A1, Child A2, Child B1, Child B2, show the parent as an empty array.

parent: {
  data: [ ]
}
CommentFileSizeAuthor
#8 2775635-8.patch459 bytesdagmar

Comments

dagmar created an issue. See original summary.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Status: Active » Postponed

Postponed until #2543726: Make $term->parent behave like any other entity reference field, to fix REST and Migrate support and de-customize its Views integration is resolved, since that is probably causing this.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Title: Parent is always empty for taxonomy terms » [BUGFIX] Parent is always empty for taxonomy terms
dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar at Globant commented

BTW I tested the last version of the patch #2543726: Make $term->parent behave like any other entity reference field, to fix REST and Migrate support and de-customize its Views integration and works out of the box fine :)

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented

@dagmar that is fantastic news! Thanks for your work on this.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar at Globant commented
Status: Postponed » Active

Alright, not so fast :( I found a bug on the relationships that doesn't have a parent (like root terms). They have a 

[parent] => Array(
  [x-default] => Array(
    [0] => Array(
      [target_id] => 0
    )
  )
)

It seems jsonapi is not considering the entity id could lead to a broken entity with id 0. Moving this to active so we can provide a pach to fix this.

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar at Globant commented

This is the fatal error:

TypeError: Argument 2 passed to Drupal\jsonapi\RelationshipItem::__construct() must implement interface             
               Drupal\Core\Entity\EntityInterface, null given, called in /var/www/cms/modules/contrib/jsonapi/src/Relationship.php 
               on line 78 in Drupal\jsonapi\RelationshipItem->__construct() (line 50 of                                            
               /var/www/cms/modules/contrib/jsonapi/src/RelationshipItem.php) #0                                                   
               /var/www/cms/modules/contrib/jsonapi/src/Relationship.php(78):                                                      
               Drupal\jsonapi\RelationshipItem->__construct(Object(Drupal\jsonapi\Configuration\ResourceManager), NULL,            
               Object(Drupal\jsonapi\Relationship), 'target_id'
dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar at Globant commented
Status: Active » Needs review
StatusFileSize
new 2775635-8.patch459 bytes

This fix the issue. But maybe there is another way to fix this properly.

  • e0ipso committed de18201 on 8.x-1.x authored by dagmar 
    Issue #2775635 by dagmar: [BUGFIX] Parent is always empty for taxonomy...
e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Status: Needs review » Fixed

:boom:

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mikl’s picture

mikl CreditAttribution: mikl at Högh Digital commented

Drupal.org doesn't allow me to reopen this, but I'm pretty sure this bug has respawned. I have alpha4 installed on my site, and I'm getting the empty parents array described in this bug report.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: grimreaper at Smile commented

Hello,

I confirm that the parent relationship is empty. I have justed tested it with the last dev version of jsonapi (drupal core: 8.3.0-beta1 but I doubt it will have an impact).

I will try to provide a test for that.

EDIT: Should I open a new issue?

dagmar’s picture

dagmar
Primary language Spanish
Location Argentina
CreditAttribution: dagmar at Globant commented

#2543726: Make $term->parent behave like any other entity reference field, to fix REST and Migrate support and de-customize its Views integration is required to make this work. Did you apply that patch too?

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: grimreaper at Smile commented

Hello,

@dagmar: thanks for the reply.

I read quickly the issue and didn't see that a patch to the core was required.

After applying the patch from #2543726-96: Make $term->parent behave like any other entity reference field, to fix REST and Migrate support and de-customize its Views integration it is ok.

What I am worried now is that this core issue is against the 8.4.x-dev branch, so we have to apply a patch at least until the last trimester of 2017. Hope the patch will still apply until then.

EDIT: And the patch is not applicable on 8.3.0-rc1... I will stay on 8.3.0-beta1

khiminrm’s picture

khiminrm CreditAttribution: khiminrm commented

Hello!

I've applied patch from https://www.drupal.org/node/2543726#comment-12031743 to Drupal 8.3.2, used jasonapi 8.x-1.0 and successfully received parent of taxonomy term.

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
CreditAttribution: a.milkovsky commented

I have used the patch https://www.drupal.org/node/2543726#comment-12328568 for Drupal 8.4.0. I can see the parent relationship in JSON export.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented

@a.milkovsky that's pretty great news!

pixelwhip’s picture

pixelwhip CreditAttribution: pixelwhip at Aten Design Group commented

The above patch no longer cleanly applies to 8.4.x. It seems this can't be patched until 8.5.0 drops in March.
See See https://www.drupal.org/project/drupal/issues/2543726#comment-12320764