JSON:API (Core) 8.8x is incompatible with jsonapi_extras config [#3106297]

Problem just after switch to 8.8:
ResourceTypeRepository in method all() returns array for ResourceTypes keyed by json_api config resourceType name
WHILE method getRelatableResourceTypesFromFieldDefinition of same ResourceTypeRepository tries to match related resource types
by default convention:

return array_map(function ($target_bundle) use ($entity_type_id, $resource_types) {
      $type_name = "$entity_type_id--$target_bundle";
      return isset($resource_types[$type_name]) ? $resource_types[$type_name] : NULL;
    }, $target_bundles);

Thus returns null that is unhandled while rotes rebuild and throws error:

TypeError: Argument 2 passed to Drupal\jsonapi\Routing\Routes::Drupal\jsonapi\Routing\{closure}() must be an instance of Drupal\jsonapi\ResourceType\ResourceType, null given in /home/oos/stamkort/web/core/modules/jsonapi/src/Routing/Routes.php on line 434 #0 [internal function]: Drupal\jsonapi\Routing\Routes::Drupal\jsonapi\Routing\{closure}(false, NULL)

I have almost all resourceType overriden in my configs... This is blocker for migrating to 8.8

If I change in method all()
from

$resource_type->getTypeName() => $resource_type,

$resource_type->getJsonapiResourceConfig()->id() => $resource_type,

This works, but i do not exactly know if this will not break anything else.

Comment	File	Size	Author
#8	d88.patch	1.5 KB	olexyy.mails@gmail.com
#8	8.x-3.x: PHP 7.2 & MySQL 5.5, D8.9.1 Patch Failed to Apply

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

14 January 2020 at 12:32

olexyy.mails@gmail.com created an issue. See original summary.

Comment #2

olexyy.mails@gmail.com CreditAttribution: olexyy.mails@gmail.com commented 15 January 2020 at 07:18

Issue summary:

View changes

Comment #3

olexyy.mails@gmail.com CreditAttribution: olexyy.mails@gmail.com commented 15 January 2020 at 07:18

Issue summary:

View changes

Comment #4

edutrul CreditAttribution: edutrul as a volunteer and at Lullabot commented 15 April 2020 at 06:07

I am having this issue but in core version 8.5
I couldn't reproduce this issue locally but I did reproduce on server.
But this is already figured out in "contentacms/contenta_jsonapi": "dev-8.x-3.x" (as far as I am aware)
there's a patch for drupal/core

                "patches": {
                    "drupal/core": {
                        "Issue #2996114: Argument 2 passed to {closure}() must be an instance of ResourceType, NULL given": "https://www.drupal.org/files/issues/2019-12-03/2996114-99.patch"
                    }
                }

on server I had this issue since the patch wasn't applied even thought I was executing composer install (even If I removed web/core folder). At the end I realized when running $ composer install -vvv it said "Patch not found". So I needed to install patch software package.
$ yum install patch

Then
$ composer install -vvv
and whoala! it applied patch successfully.

Comment #5

edutrul CreditAttribution: edutrul as a volunteer and at Lullabot commented 15 April 2020 at 06:08

Status:

Active

» Reviewed & tested by the community

Comment #6

hanoii

Spanish

🇦🇷UTC-3

CreditAttribution: hanoii commented 18 April 2020 at 21:57

Status:	Reviewed & tested by the community	» Active
Related issues:		+#2996114: Argument 2 passed to Drupal\jsonapi\Routing\Routes::Drupal\jsonapi\Routing\{closure}() must be an instance of Drupal\jsonapi\ResourceType\ResourceType, NULL given

There is nothing to review and test on this issue.

Although the patch mentioned on #4 for core mitigates the issue it's really not a fix, and the issue has diverged a bit into just providing some input on what the issue is, not preventing the error.

I think this is still something valid to sort on this module.