Problem/Motivation

Type of Drupal\key\Commands\KeyCommands::$logger must be ?Psr\Log\LoggerInterface

Steps to reproduce

Use the module with Drupal 10 / PHP 8.1.

Proposed resolution

Update function declaration for \Drupal\key\Commands\KeyCommands::$logger

Remaining tasks

  • Create MR
  • Review MR
  • Merge MR

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork key-3278542

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ricovandevin created an issue. See original summary.

ricovandevin opened merge request !5

ricovandevin’s picture

ricovandevin commented
Title: D10 Compatibility | Type of Drupal\key\Commands\KeyCommands::$logger must be ?Psr\Log\LoggerInterface » D10 compatibility | Type of Drupal\key\Commands\KeyCommands::$logger must be ?Psr\Log\LoggerInterface
Status: Active » Needs review
nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Assigned: ricovandevin » Unassigned
Status: Needs review » Reviewed & tested by the community

The changes looks good, setting as RTBC.

rlhawk made their first commit to this issue’s fork.

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Reviewed & tested by the community » Needs work
nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Needs work » Needs review

I have removed the custom logger and just use the default one provided by the DrushCommands that the KeyCommands extends.

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Needs review » Reviewed & tested by the community

This looks good.

rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Title: D10 compatibility | Type of Drupal\key\Commands\KeyCommands::$logger must be ?Psr\Log\LoggerInterface » Update $logger definition to be compatible with Drupal 10

  • rlhawk committed 2c580e6 on 8.x-1.x authored by ricovandevin 
    Issue #3278542 by ricovandevin, rlhawk, nkoporec: Update $logger...
rlhawk’s picture

rlhawk
Primary language English
Location Seattle, Washington, United States
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.