Hello Team,

I have solved the coding standard please approve my patch in include it in the next release.

Thanks
-Ken

CommentFileSizeAuthor
#2 issues_3221564.patch10.6 KBKen Patolia

Issue fork login_history-3221564

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Ken Patolia created an issue. See original summary.

Ken Patolia’s picture

Ken Patolia CreditAttribution: Ken Patolia at Drupalnest LLC commented
FileSize
issues_3221564.patch10.6 KB

Ken Patolia opened merge request !1

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented

What coding standard? All of the changes proposed actually make everything way worse!

The deprecated warnings are there for a reason. Calls should REALLY be $this->t() instead of t().

I'm closing this issue, as this one is seriously wrong. If you want to have a new go at this do the following, please:

  1. Identify the coding standard problems (I just checked, there's none)
  2. Fix the identified problems
jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Active » Closed (won't fix)

jcnventura closed merge request !1