Breaking off this issue from #1662752: Maillog log table size escalation. Patch forthcoming based on code in Comment #10.

CommentFileSizeAuthor
#6 maillog_row_limit-3218598-6.patch1.94 KBTommyK
#2 maillog_row_limit-3218598-2.patch1.62 KBTommyK
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

TommyK created an issue. See original summary.

TommyK’s picture

TommyK CreditAttribution: TommyK as a volunteer commented
Status: Active » Needs review
FileSize
maillog_row_limit-3218598-2.patch1.62 KB

I've created a patch based on the code from the code in #1662752-10: Maillog log table size escalation. The only thing I changed was the `id` column name as the module has changed since the code was posted.

Credit to the original contributor.

robcarr’s picture

robcarr
Primary language English
Location Perthshire, Scotland
CreditAttribution: robcarr commented

The patch seems to work. Thanks for posting the patch: +1 for RTBC

The only problem I've observed is that the initial cron run can run out of resource/memory/time if the maillog table is quite big. I had 70,000 rows to start with, so had to manually trim the table to something close to the limit before I could get cron to run.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

This mirrors the code from dblog.module, which was a great idea.

I need to manually test it, but this is probably RTBC.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Needs work

One minor thing - it needs a hook_uninstall() line to delete the "maillog_row_limit" variable.

TommyK’s picture

TommyK CreditAttribution: TommyK as a volunteer commented
Status: Needs work » Needs review
FileSize
maillog_row_limit-3218598-6.patch1.94 KB

add a hook_uninstall() line for the maillog_row_limit variable