I did only a quick test, but it appears the image effects aren't calculating the dimension, hence breaking the picture module.

Comments

tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented

Does your setup break also without any ManualCrop image effects?

attiks’s picture

attiks commented

Nope, you need to implement a dimensions callback, see hook_image_effect_info and return the dimensions of the derivative image

matthijs’s picture

matthijs
Primary language Dutch
commented
Status: Active » Postponed

Please see #1556244: Using 'manual crop' style, and leaving the minimum height and/or width fields blank results in missing image attributes.

I guess this can't be fixed until #1364670: ImageStyle::transformDimensions unable to deal with all effects. has been done.

matthijs’s picture

matthijs
Primary language Dutch
commented
Related issues: +#1556244: Using 'manual crop' style, and leaving the minimum height and/or width fields blank results in missing image attributes, +#1364670: ImageStyle::transformDimensions unable to deal with all effects.
attiks’s picture

attiks commented

#4 You're right, but is so people know it might break picture. Only work around is to create an explicit mapping and not use the sizes option.

adarkling’s picture

adarkling commented
Status: Postponed » Active

Blocker issue was resolved -- making this an active issue again.

BrianVu’s picture

BrianVu commented

Does Manual Crop not work with the Picture Module for responsive breakpoints? My images get cropped but the Picture Module stuff is not working when i resize my screen and such...

chaloum’s picture

chaloum commented

I get two issues. One is it can produce ages of 0px but the main one is when I crop the initial image all good, but when I come back an edit the node it delegate the image from the file system.

I then have to reopen the node, click on crop, then exit the node without saving, then the image is saved in the file system