Problem/Motivation

If you create a 'media browser tab' display for a view of media items, and exposed some of the filters, then the form submit url is wrong - it's set to the url for the default display on the view, not '/media/browser'. This makes any form with exposed filters unusable, as it ends up showing the wrong page in the iframe, including the site theme header etc., once you press the 'Apply' button on the filter form.

Proposed resolution

I have managed to solve this by patching a couple of files. It's not the cleanest solution probably, but it does work OK.

I'm in the process of generating the patch now.

Remaining tasks

(done) write patch
(done) review patch

User interface changes

None

API changes

None

CommentFileSizeAuthor
#2 media-exposed-filter-fix-1975836-2.patch876 byteshighfellow
#1 media-exposed_filter_fix-1975836-1.patch1.23 KBhighfellow
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

highfellow’s picture

highfellow CreditAttribution: highfellow commented
FileSize
media-exposed_filter_fix-1975836-1.patch1.23 KB

I've attached a patch file to this comment. (Created using git diff as explained at http://drupal.org/node/707484).

highfellow’s picture

highfellow CreditAttribution: highfellow commented
Issue summary: View changes
FileSize
media-exposed-filter-fix-1975836-2.patch876 bytes

There was a fault in the way I prepared the above patch. This one should work (execpt that you have to re-select the correct tab after applying the filters).

Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Status: Active » Needs review

The last submitted patch, 1: media-exposed_filter_fix-1975836-1.patch, failed testing.

SocialNicheGuru’s picture

SocialNicheGuru CreditAttribution: SocialNicheGuru commented

#2 worked for me. thanks.

Yuri’s picture

Yuri CreditAttribution: Yuri commented

#2 worked.
Any idea what could be a workaround to not having to reselect the tab?

svenryen’s picture

svenryen CreditAttribution: svenryen commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

I can also confirm #2 works for me.

aaron’s picture

aaron CreditAttribution: aaron commented
Status: Reviewed & tested by the community » Fixed

Committed to http://drupalcode.org/project/media.git/commit/a86d0da.

  • aaron committed a86d0da on 7.x-2.x 
    Issue #1975836 by highfellow: fixed Exposed form in media browser view...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

prashant.kabade’s picture

prashant.kabade CreditAttribution: prashant.kabade commented

This patch worked successfully . It should be added to next update please. Thanks