Problem/Motivation

Try up add a flickr image before a Flickr API is added. The message contain wrong path to the Flickr API setting page, and a PHP warning.
Notice: Undefined index: err in _media_flickr_get_user_id() (line 203 of media_flickr/includes/media_flickr.utilities.inc).

Proposed resolution

Let _media_flickr_get_user_id() return FALSE if $info if empty.

Remaining tasks

Ideally should we also get rid of
Unable to handle the provided embed string or URL. warning when API key is missing, it is simply confusing.

User interface changes

None

API changes

None

CommentFileSizeAuthor
#1 media_flickr-2289781-1.patch2.07 KBsteinmb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

steinmb’s picture

steinmb CreditAttribution: steinmb commented
Status: Active » Needs review
FileSize
media_flickr-2289781-1.patch2.07 KB

This addressed the problem. Also correct the doc block claiming it returns a object.

  • steinmb committed 8321fd2 on 7.x-2.x 
    Issue #2289781 Improve help text and link if Flickr API is missing...
steinmb’s picture

steinmb CreditAttribution: steinmb as a volunteer commented
Status: Needs review » Fixed

commit 8321fd2794 addresses the link to module settings page.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.