The Diff module adds a revisions tab to nodes that allows users with sufficient permissions to see a breakdown of changes made to the values of each individual field, however multifield fields are displayed as a garbled block of raw html. It would be much easier for humans to parse this if instead changes to individual subfield values could be displayed.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | json_diff-2745585-8.patch | 1.99 KB | itamar |
| #7 | multifield.png | 503.47 KB | mustanggb |
| #3 | Selection_410.png | 18.59 KB | dave reid |
| #3 | Selection_409.png | 92.89 KB | dave reid |
| #3 | 2745585-diff-integration.patch | 2.49 KB | dave reid |
Comments
Comment #2
mustanggb commentedBy the looks of it this entails implementing a multifield_field_diff_view().
Comment #3
dave reidI think this look like it resolves it.
Before:
After:
Comment #4
dave reidI also found a bunch of issues related to revisions and image/file fields that were fixed separately in #2750435: When creating new revision, file usage is not preserved correctly, but I noticed them due to this issue!
Comment #6
dave reidTested and committed #3 to 7.x-1.x. Now working on adding tests.
Comment #7
mustanggb commentedSo I tested the patch and whilst it does make it less messy, it's not really easier to understand what it's showing you.
I've attached an example of what I mean, with a suggestion of how it could be displayed in a more understandable way.
Comment #8
itamar commentedThe current solution doesn't allow to distinguish between different multifield items.
This patch encodes each multifield as json, to allow displaying multifields separately.