tableHeaderOffset not set / Sticky header overlayed by navbar, causes AJAX errors (ex: Views UI)

We're working to fix this in D8 first.

#1847084: Measure/track displacing elements better + provide change events for them (fix overlay + toolbar)

This should be fixed in the 7.x-1.x branch.

I am reopening this as it still needs work. See screenshot using latest Navbar.

hass gets credit here for noting the Drupa.settings.tableHeaderOffset method in his patches. I extended this approach with the Drupal.displace method that Navbar includes. And I'm only adding the library that implements this method and setting if the tableheader script is being loaded on the page.

committed in b9ba113aa794fd8082dcddbee222cb3843ce0316, I'm leaving as needs review for verification of the fix.

Removing the rc-blocker tag.

drupal_add_library do not work on js alter when use ajax_delivery. See ajax_render. It is added only settings without file navbar-tableheader.js
This patch fix it

Hi. Patch at #20 worked well for me.

I was seeing problems with Views UI when there were AJAX commands coming back. Instead of them being processed correctly, exception was being thrown in Javascript (TypeError: 'undefined' is not a function (evaluating 'Drupal.navbar.height()') ) and then the JSON data was being displayed in browser (Safari).

Patch at #20 solves it for me. I suggest

Patch #20 solves my Views + Ajax problems as well.

#20 fixed my issues also

#20 fixes the excruciating clash between this module and views_ui.

#20 fixes my issue with Panels and Panopoly when adding a new table field using IPE.

Patch #20 breaks the tabs in the Media module WYSIWYG browser. Not the initial tabs but after clicking next in the media browser when uploading an image.

Attached are screenshots of the issue and comparison with the correct state.

I needed to make a slight modification to hook_js_alter to only add Drupal.navbar is the navbar.js itself is added first. This let me use the admin_select module with admin_menu for users who wishes to use that combo instead.

Attaching patch.

Whoops wrong patch.

This was also causing javascript errors in Drupal.tableHeader.eventhandlerRecalculateStickyHeader in Views UI. The patch resolved it.

Can I suggest the title of this issue be changed to reflect its todo with AJAX. It is only by chance that I found that this patch resolved the issue I was having.

re: #31 - I will review...

+++ b/navbar.module
@@ -901,9 +898,9 @@ function navbar_library_alter(&$libraries, $module) {
-  // is loaded.

On #34, I don't think this comment should be removed with the patch.

+++ b/navbar.module
@@ -901,9 +898,9 @@ function navbar_library_alter(&$libraries, $module) {
   // Only load the tableheader offset script if the core tableheader script
-  // is loaded.
-  if (isset($javascript['misc/tableheader.js'])) {
-    drupal_add_library('navbar', 'navbar.tableheader');
+  // and the navbar js itself is loaded.

That seems correct to me, actually.

"Only load the tableheader offset script if the core tableheader script and the navbar js itself is loaded"

Though for correct grammar one might say say, "Only load the tableheader offset script if the core tableheader script and the navbar js are loaded"

I feel like I am nitpicking there though.

oops, sorry I misread the patch file in #31. Ignore my previous comment.

#34 tested and works.

@gmclelland if you wish to mark needs work with an updated comment, that's fine by me.

Trying to avoid patching this myself so I can still RTBC it :)

Can confirm #31 applies and works and gets rid of the error in the console. We are using 7.x-1.4+9-dev for what it is worth.

Please consider this a 2nd RTBC although I am not sure why there are two comments referencing #34, #34 does not have a patch attached.