Problem/Motivation

Port the module to Drupal 8.

Proposed resolution

Made the port.

Remaining tasks

I'm listing here only the main tasks that we need to consider (or are implemented at this moment) to made the migration, the additional tasks that can improve the module functionalities are not listed here because we can consider the module ported without them.

#2910678: Create a permission to configure the module settings
#2911115: Create the settings and schema files
#2911117: Manage the module configuration
#2911119: Create the module help page
#2911120: Create a Confirm Form to delete the content type configuration
#2911122: Add the configuration options to each content type edit form
#2911123: Add the 'Limit the amount of revisions for this content type' option in the Publishing option vertical tab
#2911128: Keep revisions during a certain time
#2911129: Delete revision by life time
#2911131: Add a config variable to configure the time for the 'when_to_delete' and 'minimun_age_to_delete' variables
#2911132: Add a config variable to configure the minimum_revisions_to_keep variable
#2911135: Create an option group in the content type edit form
#2911134: Create the CHANGELOG.txt file
#2911133: Disable the 'Delete revisions now' option if there not exists candidates nodes with revisions to delete
#2911126: Drush command to get how many revisions will be deleted per cron run
#2911124: Drush command to configure how many revisions delete per cron run
#2907680: Add the sticky property to the table shown in the admin page
#2895498: Drush command to get the last time that the node revision delete was made
#2899066: Drush command to configure frequency with which to delete revisions while cron is running
#2899740: Drush command to configure time options to know when the revision should be deleted
#2900518: Drush command to configure time options for the minimum age to delete revisions
#2911844: Identify the candidate nodes with revisions to delete
#3076167: Identify the candidate revisions to delete
#2915292: Delete node revisions on the module config page
#3077318: Delete revisions when cron runs

We need to add a task to allow the deletion on cron run, for the moment is possible to delete revisions but only from the configuration page.

User interface changes

None.

API changes

None.

Data model changes

None.

Comments

echoz created an issue. See original summary.

vbouchet’s picture

vbouchet
Location Toulouse
CreditAttribution: vbouchet as a volunteer commented

I am currently working on an Entity Revision Delete module which won't only focus on nodes. I will update this ticket as soon as I have something working.

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar at QED42 commented
Assigned: Unassigned » yogeshmpawar

I am working on this port to drupal 8.

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented

Any update on this? I can help because I need this module for a client. where I can found the code for the Drupal 8 version?

yogeshmpawar’s picture

yogeshmpawar
He/Him/His
Primary language English
Location 🇮🇳 Pune(MH)
CreditAttribution: yogeshmpawar at QED42 commented
Assigned: yogeshmpawar » Unassigned

sorry @adriancid - currently i am not working on this module.

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented

Work in progress at https://github.com/adrian-cid/node_revision_delete

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented
Assigned: Unassigned » adriancid
Status: Active » Needs review

8.x-1.0-alpha1 released in https://github.com/adrian-cid/node_revision_delete/releases/tag/8.x-1.0-...

For the moment only is posible to create, edit and delete the module configuration. I think that this is the first step, will be great if somebody can review the code and made some sugestions to continue with the work.

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented

8.x-1.0-alpha2 released in https://github.com/adrian-cid/node_revision_delete/releases/tag/8.x-1.0-...

For the moment only is posible to create, edit and delete the module configuration. Somebody can review the code and made some suggestions to continue with the work?

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented
Version: 7.x-3.x-dev » 7.x-2.x-dev
adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented
Title: Drupal 8 port? » Node Revision Delete Drupal 8 port
adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented
Version: 7.x-2.x-dev » 8.x-1.x-dev

The 8.x-1.x branch is now here in drupal.org

terminator727’s picture

terminator727 CreditAttribution: terminator727 commented

Drush (8):
$ drush en node_revision_delete
node_revision_delete is incompatible with the PHP version.
i tested it on ubuntu 14.04 (local) with 5.5.9-1ubuntu4.21

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented

@simon.b You need php 5.6 or superior, is described in the .info.yml file and in the admin/modules page.

terminator727’s picture

terminator727 CreditAttribution: terminator727 commented

oh ok, sorry, php upgraded to 5.6.30-12 and works fine! :) but the drush support doesn't work (drush node-revision-delete)

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented

@simon.b sorry for this late answer, I just see the message now.

If you go to see the release notes you can read:

For the moment is only posible create, edit and delete the module configuration.

An the only drush command at this time is:

drush nrd-delete-cron-run
Configures how many revisions delete per cron run.

The module is currently being ported to Drupal 8, but will be great if you can review the code and write your opinion about the work.

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented
Category: Feature request » Plan
Issue summary: View changes
adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented
Issue summary: View changes
adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer commented

I think that to release the first functional beta we need to finish at least the two last tasks in the issue description:

#2911844: Identify the candidate nodes with revisions to delete
#2915292: Delete node revisions on the module config page

adam-delaney’s picture

adam-delaney CreditAttribution: adam-delaney commented

We are a team of developers with an interest and capacity to work on the Drupal 8 version of this module. We have some time within the next two weeks to look into issue: https://www.drupal.org/project/node_revision_delete/issues/2911844. We will have more time starting in the middle of July to start looking at issue: https://www.drupal.org/project/node_revision_delete/issues/2915292. We would like to know how we can best contribute to get this project functional for D8. Here are a few questions we have in regards to the outstanding tickets.

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer and at Drupiter commented

Hi @adam-delaney, I think we need to finish first the #2911844: Identify the candidate nodes with revisions to delete issue to identify the candidate nodes with revisions to be deleted. In the issue there is a patch, I tried to review the patch but I think is incomplete and with many lines to something that should be more simple.

What you need to know to move forward this task is that we need to have in mind that a content type can have 3 different configurations related with the deletion of nodes, if you go to the content type edit page you will see it.

image

adam-delaney’s picture

adam-delaney CreditAttribution: adam-delaney commented

@adriancid, thanks for the feedback. After manually scanning the patch for https://www.drupal.org/project/node_revision_delete/issues/2911844, it appears that there are several methods that are incomplete. Can you provide more information on how we should move forward with this issue? Do we think the latest patch is a good starting point and just needs to be completed or do you have concerns with the direction of the patch and needs a complete refactor?

adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer and at Drupiter commented

I think that is better to star a new patch.

adam-delaney’s picture

adam-delaney CreditAttribution: adam-delaney at Principal Financial Group commented
adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer and at Drupiter commented
Issue summary: View changes
adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer and at Drupiter commented
Status: Needs review » Needs work
adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer and at Drupiter commented
adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer and at Drupiter commented
Issue summary: View changes
adriancid’s picture

adriancid
Primary language Spanish
Location Montreal, Canada
CreditAttribution: adriancid as a volunteer and at Drupiter commented
Issue summary: View changes
Status: Needs work » Fixed

The port is finished but we need more test before the 8.x-1.0 release, in the next days I will release the beta2.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.