Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.We need to get layout plugin type from somewhere, which can be used by our PanelsDisplayVariant class.
I see three possible options:
- Implement a layout plugin type in Panels. This might be a good temporary solution, so that we can move forward and have something that seems Panels-y.
- Get the layout plugin type into Drupal core. I don't know the core teams feelings about this, but here is an issue to discuss it: #2296423: Implement layout plugin type in core
- Depend on a 3rd party module that declares one. frega has refactored just the plugin part of his 'layout' module on GitHub into a sandbox on Drupal.org called 'layout_plugin'.
Since we need layouts to move forward on the D8 port, we may end up choosing two options: one temporary solution for now, and another for the long-term.
Sandbox branch
http://cgit.drupalcode.org/sandbox-dsnopek-2290237/log/?h=layouts-2296431
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | panels-layout-plugin-2296431-8.patch | 11.63 KB | dsnopek |
Comments
Comment #1
dsnopekComment #2
dsnopekComment #3
dsnopekfrega has refactored just the plugin part of his 'layout' module on GitHub into a sandbox on Drupal.org. I think this is the way to go for now!
Comment #4
dsnopekI've started working on this in the 'layouts-2296431' branch on the 'd8panels' sandbox:
http://cgit.drupalcode.org/sandbox-dsnopek-2290237/log/?h=layouts-2296431
The admin forms are all working, but I'm getting an error when trying to render the page. Strangely, nothing is appearing in my error log. :-/
Comment #5
dsnopekHere is the first sort of working patch to use the layout_plugin module to provide layouts.
However, it's blocked by a couple of issues in layout_plugin:
Comment #6
dsnopekHere's a new version of the patch!
Updates include:
Comment #7
dsnopekRemoved some left over cruft from a previous approach.
Comment #8
dsnopekChasing HEAD!
Comment #10
japerryLooks good for a first run! If we need to keep making updates to keep up with core, lets keep it here. Otherwise if there are new issues, make a separate issue for it.