Revisions are not reflected on parent node's revision log [#3065643]

This one is pretty straightforward. As of 8.5.x, when updating a paragraph using the paragraphs_edit contextual links, a revision is created on the parent node but is not reflected on the revision log due to translation mismatch. The content_translation module does not need to be enabled for this to be a problem.

Steps to reproduce:

Enable paragraphs_edit module.
Create new node with paragraphs-enabled field.
Edit node normally (node/[node:id]/edit) => Revision created + reflected on revision tab (node/[node:id]/revisions).
Edit node via contextual link on paragraph provided by this module => Revision created but does not show up on revisions.

This is a problem because content editors do not have the ability to roll back to previous revisions if needed.

Comment	File	Size	Author
#2	paragraphs_edit-better-revisions-3065643-2.patch	546 bytes	joelstein

Issue fork paragraphs_edit-3065643

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3065643-revisions-are-not changes, plain diff MR !13
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

3 July 2019 at 13:04

rpc5102 created an issue. See original summary.

Comment #2

joelstein CreditAttribution: joelstein at On Fire Media commented 5 November 2019 at 15:47

Version:	8.x-2.0-alpha6	» 8.x-2.x-dev
Status:	Active	» Needs review
Related issues:		+#2914976: Revisions log does not attribute author or timestamp correctly

Status	File	Size
new	paragraphs_edit-better-revisions-3065643-2.patch	546 bytes

Great catch and thanks for referencing #2924724: Add an API to create a new revision correctly handling multilingual pending revisions. From the commit at https://git.drupalcode.org/project/drupal/commit/db9c0e6, I created a patch which uses the ContentEntityStorageBase::createRevision() to create the revision, which more gracefully sets everything up for revisions and translations.

Also see #2914976: Revisions log does not attribute author or timestamp correctly where I'll post an updated patch to fix the revision author and created timestamp.