Unable to append short external urls as first breadcrumb [#2067579]

I am working on a site where the main page is a sub-section of a larger (non-drupal) website. So I wanted to add the url of the main website as the first breadcrumb item. So I implemented hook_path_breadcrumbs_view_alter() and successfully added the a new breadcrumb item to the front of every trail.

However, the module kept rewriting my url. I did some digging and found the issue was at line 354 of path_breadcrumbs.module. So I hacked a quick solution that changes $href = ''; to $href = $matches[1]; on line 355. So I guess I am curious what cases you are trying to catch with this if statement:

// Means that this is href to the frontpage.
if (drupal_strlen($base_string) > drupal_strlen($matches[1])) {

Are you trying to catch cases where people hardcode example.com as the front page url, instead of using <front>?

So I guess if you could clarify what you are trying to catch, then I can put together a quick patch to still catch those situation, while allowing situations like mine to pass through un-altered.

Thanks.

Comment	File	Size	Author
#6	2066223-path_breadcrumbs_test_export.txt	855 bytes	kalabro

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

kalabro

she/her

CreditAttribution: kalabro commented 19 August 2013 at 05:47

Hello, @adamzimmermann!
As I know external URLs are not working correctly if you use PB render function for breadcrumbs. We will fix it soon.

Are you trying to catch cases where people hardcode example.com as the front page url, instead of using ?

It is because PB parses any breadcrumbs (from other modules for example) if setting “Use module breadcrumbs render function” is enabled.

Comment #2

kalabro

she/her

CreditAttribution: kalabro commented 29 September 2013 at 16:03

Version:	7.x-3.0-beta4	» 7.x-3.x-dev
Status:	Active	» Needs review

Now this statement replaced: http://drupalcode.org/project/path_breadcrumbs.git/commitdiff/152afe6

@Spleshka, could you please explain why it was used initially?

Comment #3

kalabro

she/her

CreditAttribution: kalabro commented 29 September 2013 at 16:06

Assigned:

Unassigned

» Spleshka

Let's ask him.

Comment #4

Spleshka

he/him

English

UAE

CreditAttribution: Spleshka commented 29 September 2013 at 16:18

Status:

Needs review

» Needs work

Heh, unfotrunately, I don't remember the exact reason. I used to spend a lot of time debugging this and found a way of solving several issues with such condition. Maybe it help to deal with the cases when drupal located in subfolder. Or maybe for subdomains. I really can't tell you exactly.

So if you want to put this instead, please test all cases with different $base_url and different breadcrumbs. Note that administrative and custom breadcrumbs are build differently, so please check this too.

Comment #5

kalabro

she/her

CreditAttribution: kalabro commented 29 September 2013 at 16:37

Assigned:

Spleshka

» Unassigned

Ok, let's test it more carefully.

Comment #6

kalabro

she/her

CreditAttribution: kalabro commented 30 September 2013 at 18:44

File	Size
2066223-path_breadcrumbs_test_export.txt	855 bytes

So, we need manual tests on latest HEAD in these cases:

Normal domain (example.com)
Subfolder (example.com/subfolder)
Subdomain (subdomain.example.com)

In each case we have to:

Enable PB render function.
Add second language (RU, for example) and enable URL detection method.
Test Path Breadcrumbs variant with front, internal and external links (example attached) with and without language prefix.
Check system breadcrumbs (which are not built with PB) with and without language prefix.
Check administrative breadcrumbs with and without language prefix.

Any help!