Add support for complete menu trail

Looking forward for you patch ;)

1. %node context can be used not only on node pages (node/%node). Imagine something like mypage/%node/%referenced_node/photos/recent. So I guess we can't just use menu_get_active_trail() with Node context. Instead we have to load menu according to given node (token_node_menu_link_load() as an example).
   Alternatively we can provide something like %site:current-page:menu:pb-join:url to clarify that menu_get_active_trail() is used.
2. I personally suggest to use consistently pb-join token in this manner: node:menu-link:pb-join.

@Manuel,

I think you may copy the code from token module. No need to add an extra dependency because of few lines of code.

OK I will implement this behaviour.

Sounds great! :)

Do you think we can use the function token_node_menu_link_load()

Why not? I suggest to add check is_callable/function_exists because PB doesn't require Token module. Token "menu-link" is provided by Token module (not by core or Entity Token), so it is quite clear that we need Token module enabled to use "node:menu-link:...". We also can add a note in docs/FAQ that "node:menu-link:pb-join:" requires Token module.

Do you have a hint how to add this as site:[...] is not an entity and in this case we cannot add new properties in the way we can with a node object.

Entity API provides special site metadata: http://drupalcode.org/project/entity.git/blob/refs/heads/7.x-1.x:/module...
So Path Breadcrumbs UI can autocomplete %site tokens. Simple Token API can be also used but w/o autocomplete.

Could you please introduce "node:menu-link:pb-join:..." property, not "node:pb-join:..."? Maybe just as simple struct.
Also see my notes from #7.
There are minor code style errors in your patch (tabs instead of whitespaces, comment style, if statements and etc).

I will help with committing it in PB repo in next few days.

@kalabro,

But why do we need Token module and its :menu-link token? We may provide custom token so we can access all menu hierarchy like node:pb-menu-join:name and node:pb-menu-join:url. I'm not sure that we have to stick to the Token's code or behavior.

The same with site:current-page:pb-menu-join:name and site:current-page:pb-menu-join:url. Doesn't it look more unified and independent from other code?

But why do we need Token module and its

We don't need but we can successfully reuse its code base and well-known token "menu-link". See #1823030: Add ability to build the breadcrumb path based on menu hierarchy
For example:

• %site:name - %site:url
• %node:menu-link:pb-join:name - %node:menu-link:pb-join:url
• %node:menu-link:title - %node:menu-link:url
• %node:field-category:pb-join:name - %node:field-category:pb-join:url

Doesn't it look clear and consistent?

Okey, but what if Token module is disabled? Which tokens will be used for the same puproses as you described?

If Token is disabled all %node:menu-link:... are not replaced (common behaviour for unknown tokens).
I don't mind to add one more custom pb-* token. It was just my opinion based on issue queue experience.
In case of #7 we can solve multiple tasks for different PB users:
1) Provide autocomplete for "menu-link" token (which is now not available)
2) Add new feature from this topic (complete menu trail)
3) Keep things simple for end user

If we don't want to make user enable Token module for node menu hierarchy we can create our own implementation of token_node_menu_link_load() (as in #6), but still place :pb-join under "%node:menu-link:" so it will work with and without Token module.

So here are our tasks:

1. Provide "menu-link" simple structure for nodes
2. Implement "%node:menu-link:pb-join:..." (with own _node_menu_link_load() function)
3. Add %site:current-page:menu-link:pb-join:... as in #2
4. Write docs.

What do you think guys?

100% agree. Lets implement this!

Finally!

1. Node token (no Token module required):
%node:menu-link:pb-join:name / %node:menu-link:pb-join:url / %node:menu-link:title

Implemented with Token API. Entity Property API is used only for autocomplete.

2. Current page menu (no Token module required):
%site:current-page:menu-link:pb-join:name / %site:current-page:menu-link:pb-join:url / %site:current-page:menu-link:title

3. Book module support (no autocompete yet):
%node:book:pb-join:name / %node:book:pb-join:url

Commit: http://drupalcode.org/project/path_breadcrumbs.git/commitdiff/b124741

Wow, very cool! Thanks a lot!

This feature is now in 7.x-3.0-beta7 release.
Docs in FAQ: https://drupal.org/node/2061955#menu-trail