ArgumentCountError appears when using ECA [#3330142]

Problem/Motivation

Not sure if this is a one off problem to my setup, or if this is a fix needed globally. I have the payment module installed and working fine... but after installing the ECA module and the ECA model interface BPMN.IO, I received the below error when trying adding a new ECA model.

ArgumentCountError: Too few arguments to function Drupal\payment\Plugin\Action\UnsetLineItem::__construct(), 3 passed in /web/core/lib/Drupal/Core/Plugin/Factory/ContainerFactory.php on line 25 and exactly 4 expected in Drupal\payment\Plugin\Action\UnsetLineItem->__construct() (line 37 of /web/modules/contrib/payment/src/Plugin/Action/UnsetLineItem.php)

Comment	File	Size	Author
#2	3330142-1.patch	753 bytes	chucksimply
#2	8.x-2.x: PHP 7.3 & MariaDB 10.3.22, D9.4.7 558 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

29 December 2022 at 12:52

chucksimply created an issue. See original summary.

Comment #2

chucksimply CreditAttribution: chucksimply commented 29 December 2022 at 12:53

File	Size
3330142-1.patch	753 bytes
8.x-2.x: PHP 7.3 & MariaDB 10.3.22, D9.4.7 558 pass

The attached patch fixes this on my end. Please review. Curious if these lines needs to be applied to other files as well?

Comment #3

chucksimply CreditAttribution: chucksimply commented 29 December 2022 at 12:54

Status:

Active

» Needs review

Comment #4

boby_ui CreditAttribution: boby_ui as a volunteer commented 3 August 2023 at 03:36

+1 confirmed that it fixed the ECA with payment issues!!

Comment #5

mxh

German

Offenburg

CreditAttribution: mxh as a volunteer and commented 2 April 2024 at 18:09

Patch of #2 makes sense. Currently there is an implementation as follows within Drupal\payment\Plugin\Action\UnsetLineItem:

<?php
/**
   * {@inheritdoc}
   */
  public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {
    return new static($configuration, $plugin_id, $plugin_definition, $container->get('string_translation'));
  }
?>

but the plugin currently does not implement the according interface, which prevents other components from properly recognizing the instantiation method, leading to the problem reported here.