When you run the core migration using Migrate Drupal UI, the two fields provided by the Physical module are not picked up.

CommentFileSizeAuthor
#7 physical-n3163742-7.patch2.93 KBDamienMcKenna
#6 physical-n3163742-6.patch2.74 KBDamienMcKenna
#6 physical-n3163742-6.interdiff.txt1.98 KBDamienMcKenna
#4 physical-n3163742-4.patch1.88 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Title: Migrate plugin for dimensions field » Migrations not picked up by core migrations
Issue summary: View changes
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Issue summary: View changes
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
physical-n3163742-4.patch1.88 KB

WIP. This doesn't work yet, but it seems like these are the pieces that were needed.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
physical-n3163742-6.interdiff.txt1.98 KB
physical-n3163742-6.patch2.74 KB

Added getFieldType(), getFieldFormatterMap() and getFieldWidgetMap() to both.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
FileSize
physical-n3163742-7.patch2.93 KB

This is getting closer.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Title: Migrations not picked up by core migrations » Add support for migrating from D7
Issue tags: +Needs tests

Test coverage would probably be useful too.

Lukas von Blarer’s picture

Lukas von Blarer
he/him
CreditAttribution: Lukas von Blarer at ATTRIBUTE for ATTRIBUTE commented

Works for me. Thank you!

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Needs work
Issue tags: +migrate-d7-d8

FWIW it works for me to convert both Weight and Physical Dimensions fields. That said, test coverage would be very useful.