Integrate with VBO [#735222]

Comment	File	Size	Author
#6	gmail example.png	6.8 KB	robby.smith

Comment #1

BenK CreditAttribution: BenK commented 7 March 2010 at 18:41

Keeping track of this module...

Log in or register to post comments

Comment #2

crea CreditAttribution: crea commented 8 March 2010 at 13:15

Some notes:
messages can't be tagged because tag is a property of a thread. So we have to limit operations depending on whether we show message threads or messages.

Log in or register to post comments

Comment #3

YK85 CreditAttribution: YK85 commented 10 March 2010 at 04:23

Version:

» 6.x-1.x-dev

Hello crea,

I was wondering if #660092: Use tag for inbox handling will help in allowing tagging of messages?
or can it be brought up to maintainers of Privatemsg to make tagging something compatible here?

Log in or register to post comments

Comment #4

crea CreditAttribution: crea commented 10 March 2010 at 08:21

#660092: Use tag for inbox handling is not for tagging, but for managing "inbox" concept. Privatemsg_views module doesn't have "inbox" yet and it's unclear if we need one.

Log in or register to post comments

Comment #5

YK85 CreditAttribution: YK85 commented 10 March 2010 at 08:37

Thanks for the explanation on the above link.

I believe Inbox will be useful to have:
A new message that I send first (but no reply received yet) won't show in Inbox, but will show in All messages and Sent messages. Then once I receive a reply the thread will be shown in Inbox. I would prefer not to see a thead in My Private Messages if I am the only one in the thread still =) also this is the flow of gmail I believe.

Inbox
Sent Message
All messages

Log in or register to post comments

Comment #6

robby.smith CreditAttribution: robby.smith commented 12 March 2010 at 13:13

File	Size
gmail example.png	6.8 KB

It would be awesome if we could have the VBO actions to look like gmail style as a default
Also the - Select: All, None, Read, Unread, Starred, Unstarred
Is this a possibility? Thanks!

Log in or register to post comments

Comment #7

crea CreditAttribution: crea commented 15 March 2010 at 13:38

@robby.smith
We only provide actions. The look and feel completely depends on VBO module.

Log in or register to post comments

Comment #8

crea CreditAttribution: crea commented 15 March 2010 at 13:43

@yaz085:
"Inbox" and "Sent" are useful in rare cases, and can be confusing to users together with thread concept, as I pointed out in #735094: Make "inbox" and "sent" menu items optional in the filter Module. Also proper sorting inside "inbox" and "sent" thread views is a complicated task #737406: Sort threads by last time of {participation type} of a user. Because of that, I put "inbox" and "sent" views feature in the end of my priority list.

Log in or register to post comments

Comment #9

crea CreditAttribution: crea commented 15 March 2010 at 13:43

Status:

Postponed

» Active

Log in or register to post comments

Comment #10

crea CreditAttribution: crea commented 16 March 2010 at 18:57

Damn. Privatemsg has implementation of hook_OBJECT_operations() which follows hook_node_operations() pattern. VBO is ready to use it, but because there's no pm_threads table with thread_id primary key, we can't use it! VBO expects us to provide object id as primary key of Views "base table". This totally sucks, because we have to reimplement all actions which are already there.

Log in or register to post comments

Comment #11

YK85 CreditAttribution: YK85 commented 17 March 2010 at 00:52

Hi crea,

Any possibility of discussing with Berdir to make changes to Privatemsg that would make integration friendlier?

Thanks!

Log in or register to post comments

Comment #12

crea CreditAttribution: crea commented 17 March 2010 at 01:50

Well, yes I am already discussing it in #744374: Introduce a pm_thread table. Though DB schema changes won't come fast so I will probably make my own workarounds anyway. This is not blocking us, proper DB schema is simply a way of making VBO integration work better for us. VBO integration will work anyway, but with simple tricks.

Log in or register to post comments

Comment #13

crea CreditAttribution: crea commented 24 March 2010 at 04:55

Status:

Active

» Fixed

I've committed initial integration with VBO. Only 2 actions are supported, cause we don't support Privatemsg sub-modules yet: "mark read" and "mark unread".
New actions will be implemented together with their respective modules integration.

Log in or register to post comments

Comment #14

7 April 2010 at 05:00

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Log in or register to post comments

Comment #15

robby.smith CreditAttribution: robby.smith commented 10 April 2010 at 09:15

Status:

Closed (fixed)

» Active

hi crea

sorry to open this back up but i'm getting lots of errors when using the newly integrated vbo actions

    * warning: array_fill() [function.array-fill]: Number of elements must be positive in /srv/www/example.com/public_html/beta/includes/database.inc on line 253.
    * warning: implode() [function.implode]: Invalid arguments passed in /srv/www/example.com/public_html/beta/includes/database.inc on line 253.
    * user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 query: SELECT DISTINCT(pmi.thread_id) FROM pm_index pmi WHERE pmi.mid IN () in /srv/www/example.com/public_html/beta/sites/all/modules/privatemsg_views/includes/privatemsg_views.vbo.inc on line 96.
    * warning: array_fill() [function.array-fill]: Number of elements must be positive in /srv/www/example.com/public_html/beta/includes/database.inc on line 253.
    * warning: implode() [function.implode]: Invalid arguments passed in /srv/www/example.com/public_html/beta/includes/database.inc on line 253.
    * user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 query: UPDATE pm_index SET is_new = 0 WHERE uid = 1 AND thread_id IN () in /srv/www/example.com/public_html/beta/sites/all/modules/privatemsg/privatemsg.module on line 1719.
    * warning: implode() [function.implode]: Invalid arguments passed in /srv/www/example.com/public_html/beta/sites/all/modules/views_bulk_operations/views_bulk_operations.module on line 757.