Ooops. Current implementation will assume that *Simpletest Module* (contrib) is a dependency of Simpletest Example (and thus of Examples project) because of

dependencies[] = simpletest

How do we solve that? Add a version specification? Does that even do the job?

Make core have precedence when searching? That might be the wrong assumption also.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rfay’s picture

Status: Active » Needs review

I'm going to go ahead and commit 02ade24, which deals with this problem in a slightly hacky way - adding an exclusion list, the variable project_dependency_exclude_dependencies, an array of project shortnames to exclude as dependencies. The default is to exclude drupal and simpletest.

rfay’s picture

Status: Needs review » Fixed
FileSize
2.14 KB

here's the committed patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

rfay’s picture

Status: Closed (fixed) » Needs review
FileSize
891 bytes

Well, it turns out that the module leftandright has a module named taxonomy. Ugly. Adding it to the default list. I wish people wouldn't do that. Commit ad04d3a

rfay’s picture

I think the exclusion list needs to check at processing time as well? Currently it's just winnowing out things that might be core modules at dependency calculation time.

rfay’s picture

Status: Needs review » Fixed

Pushed

rfay’s picture

Yet another problem is the 'category' module, which also squats on "taxonomy". I'm excluding it.

Here's how to update the project_dependency_excluded_dependencies variable:

php -r "print json_encode(array('drupal', 'simpletest', 'leftandright', 'category'));"  | drush vset --format=json project_dependency_excluded_dependencies -

Edit: And then rebuild the dependencies for vote_up_down, which was the problem here, see #1299888: Bot error: failed to complete installation by setting admin username/password/etc:

drush pdpp vote_up_down
drush pdsd vote_up_down 6.x-2.x-dev

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

rfay’s picture

Status: Closed (fixed) » Needs work

Had to update this tonight because of a profile, b2b_store_solution which has all these modules included in it.

php -r "print json_encode(array('drupal', 'simpletest', 'leftandright', 'category', 'b2b_store_solution'));"  | drush vset --format=json project_dependency_excluded_dependencies -

It *must* not be set up right though, because it's actually including the modules.

However, after doing this, the dependencies for commerce were not right (missing ctools).

rfay’s picture

And now the same problem because of the onepagecv project.

php -r "print json_encode(array('drupal', 'simpletest', 'leftandright', 'category', 'b2b_store_solution', 'onepagecv'));"  | drush vset -y --format=json project_dependency_excluded_dependencies -

Also needs exclusion from dependencies, #1327352: Resolve issues caused by rogue install profile b2b_store_solution and onepagecv

rfay’s picture

For rebuilding, I created the jenkins job /job/project_dependency_rebuild_project/

rfay’s picture

Latest:

php -r "print json_encode(array('drupal', 'simpletest', 'leftandright', 'category', 'b2b_store_solution', 'onepagecv', 'testbot_exercise', 'opendeals', 'corporative_site', 'rulesmonkey'));"  | drush vset -y --format=json project_dependency_excluded_dependencies -
rfay’s picture

starterkit_touchpro:

php -r "print json_encode(array('drupal', 'simpletest', 'leftandright', 'category', 'b2b_store_solution', 'onepagecv', 'testbot_exercise', 'opendeals', 'corporative_site', 'rulesmonkey', 'starterkit_touchpro'));"  | drush vset -y --format=json project_dependency_excluded_dependencies -
rfay’s picture

Same thing with starterkit_touchpro

rfay’s picture

And with uberpaltw

 php -r "print json_encode(array('drupal', 'simpletest', 'leftandright', 'category', 'b2b_store_solution', 'onepagecv', 'testbot_exercise', 'opendeals', 'corporative_site', 'rulesmonkey', 'starterkit_touchpro', 'uberpaltw'));"  | drush vset -y --format=json project_dependency_excluded_dependencies -
rfay’s picture

And contextual:

php -r "print json_encode(array('drupal', 'simpletest', 'leftandright', 'category', 'b2b_store_solution', 'onepagecv', 'testbot_exercise', 'opendeals', 'corporative_site', 'rulesmonkey', 'starterkit_touchpro', 'uberpaltw', 'contextual'));"  | drush vset -y --format=json project_dependency_excluded_dependencies -
rfay’s picture

And the old translation module:
php -r "print json_encode(array('drupal', 'simpletest', 'leftandright', 'category', 'b2b_store_solution', 'onepagecv', 'testbot_exercise', 'opendeals', 'corporative_site', 'rulesmonkey', 'starterkit_touchpro', 'uberpaltw', 'contextual', 'translation'));" | drush vset -y --format=json project_dependency_excluded_dependencies -

rfay’s picture

And contact
php -r "print json_encode(array('drupal', 'simpletest', 'leftandright', 'category', 'b2b_store_solution', 'onepagecv', 'testbot_exercise', 'opendeals', 'corporative_site', 'rulesmonkey', 'starterkit_touchpro', 'uberpaltw', 'contextual', 'translation', 'contact'));" | drush vset -y --format=json project_dependency_excluded_dependencies -

rfay’s picture

And file
php -r "print json_encode(array('drupal', 'simpletest', 'leftandright', 'category', 'b2b_store_solution', 'onepagecv', 'testbot_exercise', 'opendeals', 'corporative_site', 'rulesmonkey', 'starterkit_touchpro', 'uberpaltw', 'contextual', 'translation', 'contact', 'file'));" | drush vset -y --format=json project_dependency_excluded_dependencies -

rfay’s picture

Status: Needs work » Fixed

Deployed project_dependency 6.x-1.0-beta1 tonight. Could be the end of this one.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

rfay’s picture

Issue summary: View changes

php -r "print json_encode(array('drupal', 'simpletest', 'leftandright', 'category', 'b2b_store_solution', 'onepagecv', 'testbot_exercise', 'opendeals', 'corporative_site', 'rulesmonkey', 'starterkit_touchpro', 'uberpaltw', 'contextual', 'translation', 'contact', 'file', 'webform_patched'));" | drush vset -y --format=json project_dependency_excluded_dependencies -

To exclude webform_patched