Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Ooops. Current implementation will assume that *Simpletest Module* (contrib) is a dependency of Simpletest Example (and thus of Examples project) because of
dependencies[] = simpletest
How do we solve that? Add a version specification? Does that even do the job?
Make core have precedence when searching? That might be the wrong assumption also.
Comment | File | Size | Author |
---|---|---|---|
#4 | project_dependency.exclude_leftandright.patch | 891 bytes | rfay |
#2 | project_dependency.exclude_list_1276914_02.patch | 2.14 KB | rfay |
Comments
Comment #1
rfayI'm going to go ahead and commit 02ade24, which deals with this problem in a slightly hacky way - adding an exclusion list, the variable project_dependency_exclude_dependencies, an array of project shortnames to exclude as dependencies. The default is to exclude drupal and simpletest.
Comment #2
rfayhere's the committed patch.
Comment #4
rfayWell, it turns out that the module leftandright has a module named taxonomy. Ugly. Adding it to the default list. I wish people wouldn't do that. Commit ad04d3a
Comment #5
rfayI think the exclusion list needs to check at processing time as well? Currently it's just winnowing out things that might be core modules at dependency calculation time.
Comment #6
rfayPushed
Comment #7
rfayYet another problem is the 'category' module, which also squats on "taxonomy". I'm excluding it.
Here's how to update the project_dependency_excluded_dependencies variable:
Edit: And then rebuild the dependencies for vote_up_down, which was the problem here, see #1299888: Bot error: failed to complete installation by setting admin username/password/etc:
Comment #9
rfayHad to update this tonight because of a profile, b2b_store_solution which has all these modules included in it.
It *must* not be set up right though, because it's actually including the modules.
However, after doing this, the dependencies for commerce were not right (missing ctools).
Comment #10
rfayAnd now the same problem because of the onepagecv project.
Also needs exclusion from dependencies, #1327352: Resolve issues caused by rogue install profile b2b_store_solution and onepagecv
Comment #11
rfayFor rebuilding, I created the jenkins job /job/project_dependency_rebuild_project/
Comment #12
rfayLatest:
Comment #13
rfaystarterkit_touchpro:
Comment #14
rfaySame thing with starterkit_touchpro
Comment #15
rfayAnd with uberpaltw
Comment #16
rfayAnd contextual:
Comment #17
rfayAnd the old translation module:
php -r "print json_encode(array('drupal', 'simpletest', 'leftandright', 'category', 'b2b_store_solution', 'onepagecv', 'testbot_exercise', 'opendeals', 'corporative_site', 'rulesmonkey', 'starterkit_touchpro', 'uberpaltw', 'contextual', 'translation'));" | drush vset -y --format=json project_dependency_excluded_dependencies -
Comment #18
rfayAnd contact
php -r "print json_encode(array('drupal', 'simpletest', 'leftandright', 'category', 'b2b_store_solution', 'onepagecv', 'testbot_exercise', 'opendeals', 'corporative_site', 'rulesmonkey', 'starterkit_touchpro', 'uberpaltw', 'contextual', 'translation', 'contact'));" | drush vset -y --format=json project_dependency_excluded_dependencies -
Comment #19
rfayAnd file
php -r "print json_encode(array('drupal', 'simpletest', 'leftandright', 'category', 'b2b_store_solution', 'onepagecv', 'testbot_exercise', 'opendeals', 'corporative_site', 'rulesmonkey', 'starterkit_touchpro', 'uberpaltw', 'contextual', 'translation', 'contact', 'file'));" | drush vset -y --format=json project_dependency_excluded_dependencies -
Comment #20
rfayDeployed project_dependency 6.x-1.0-beta1 tonight. Could be the end of this one.
Comment #22
rfayphp -r "print json_encode(array('drupal', 'simpletest', 'leftandright', 'category', 'b2b_store_solution', 'onepagecv', 'testbot_exercise', 'opendeals', 'corporative_site', 'rulesmonkey', 'starterkit_touchpro', 'uberpaltw', 'contextual', 'translation', 'contact', 'file', 'webform_patched'));" | drush vset -y --format=json project_dependency_excluded_dependencies -
To exclude webform_patched