Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Extend the capabilities of the Entity Limit module by introducing additional limit cycles. This module offers various types of limit cycles, including daily, weekly, monthly, and yearly.
Comments
Comment #2
Dipesh k CreditAttribution: Dipesh k commentedComment #3
Dipesh k CreditAttribution: Dipesh k commentedComment #4
vishal.kadamThank you for applying!
Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
The important notes are the following.
phpcs --standard=Drupal,DrupalPractice
on the project, which alone fixes most of what reviewers would report.To the reviewers
Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.
The important notes are the following.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.
Comment #5
vishal.kadamComment #6
Rushikesh Raval CreditAttribution: Rushikesh Raval commentedI am changing the issue priority as per issue priorities.
Comment #7
vishal.kadam1. Fix phpcs issues.
2. FILE: entity_limit_extend.info.yml
core_version_requirement: ^8 || ^9 || ^10
The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement: key.
3. FILE: src/EntityLimitInspector.php
// dump("user access");.
Remove commented debug code.
Comment #8
Dipesh k CreditAttribution: Dipesh k commentedFixed phpcs issues and removed comments.
Comment #9
vishal.kadamReview feedback changes should be pushed to the review branch [1.0.x].
main is acceptable as branch name, but it is not yet fully supported on drupal.org. For the moment, it is better to avoid it.