[2.0.x] OpenSolr Turbo Indexer

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should enable GitLab CI for the project and fix the PHP_CodeSniffer errors/warnings it reports.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; once this application is closed, you will be able to change the project status from Not covered to Opt into security advisory coverage. This is possible only 14 days after the project is created.
  
  Keep in mind that once the project is opted into security advisory coverage, only Security Team members may change coverage.
• Only the person who created the application will get the permission to opt projects into security advisory coverage. No other person will get the same permission from the same application; that applies also to co-maintainers/maintainers of the project used for the application.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

• It is preferable to wait for a project moderator before posting the first comment on newly created applications. Project moderators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

I do not have time for a full review. The expected content of the LICENSE.txt file is the one Drupal core uses.

1. FILE: README.md

The README file is missing the required sections - Configuration.

2. FILE: README.txt

Remove README.txt since README.md is present.

3. FILE: opensolr.info.yml

core_version_requirement: ^9 || ^10 || ^11

A new project should not declare itself compatible with a Drupal release that is no longer supported. No site should be using Drupal 8 nor Drupal 9, and people should not be encouraged to use those Drupal releases.

4. Fix the warnings/errors reported by PHP_CodeSniffer. (see attached opensolr_turbo_indexer-phpcs-errors.txt)

NOTE: I would suggest enabling GitLab CI for the project, follow the Drupal Association .gitlab-ci.yml template and fix the PHP_CodeSniffer errors/warnings it reports.

Releases should not be created after each review done here, since a review could ask for a change that is not backward compatible with the existing releases. Just using a development version avoids those BC issues.

Some PHP_CodeSniffer errors are pending.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml opensolr_turbo_indexer/

FILE: opensolr_turbo_indexer/src/Commands/OpensolrCommands.php
--------------------------------------------------------------------------------
FOUND 15 ERRORS AFFECTING 10 LINES
--------------------------------------------------------------------------------
  34 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
  40 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
  40 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
  64 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
  69 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
  69 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
 359 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
 362 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 362 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
 581 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
 584 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 584 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
 667 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
 670 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
 670 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Rest seems fine to me.

Please wait for other reviewers and Project Moderator to take a look and if everything goes fine, you will get the role.

Thank you for your contribution and for your patience with the review process!

I am going to update your account so you can opt into security advisory coverage any project you create, including the projects you already created.

These are some recommended readings to help you with maintainership:

• Dries' post on Responsible maintainers
• Maintainership
• Git version control system
• Issue procedures and etiquette
• Maintaining and responding to issues for a project
• Release naming conventions.

You can find more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank also all the reviewers for helping with these applications.