Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The function rootcandy_system_settings_form checks that the fourth argument of the URL is a sub-theme of rootcandy, but the list of sub-themes is setted directly in the code. This patch changes the function taking a list of rootcandy sub-themes installed using list_theme function.
Thus to have the settings for the theme available for other sub-theme other by rootcandy_dark and rootcandy_fixed.
Comment | File | Size | Author |
---|---|---|---|
#5 | 535504.patch | 720 bytes | abaddon |
rootcandy_system_settings_form.patch | 868 bytes | peximo |
Comments
Comment #1
sign CreditAttribution: sign commentedVery nice! Committed
thank you
Comment #2
sign CreditAttribution: sign commentedComment #4
abaddon CreditAttribution: abaddon commentedthis patch doesnt allow me to build a subtheme of a rootcandy subtheme, the function isnt running for the subtheme and depending on automatically inheriting the theme-settings.php gets me a broken form, ive fixed it to work on base themes being other rootcandy subthemes too
my theme is a subtheme of rootcandy dark
and i can have a theme-settings.php that inherits everything hence less duplication, like:
(my subtheme is named rootcandy_custom)
Comment #5
abaddon CreditAttribution: abaddon commentedheres a patch to get things moving, and ive replaced the strpos with in_array,
to reiterate this, the initial patch in this thread fixes the case when the subtheme is a subtheme of rootcandy, but i have a subtheme of rootcandy_dark, i just had to change the IF to check for all official rootcandy themes
Comment #6
sign CreditAttribution: sign commentedlooking good, committed to dev, some testing would be nice :)