Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This issue is for any changes to be tried out on drupal.org testing infrastructure and gitlab pipelines. It is useful to have this issue open to be able to check what is happening on d.o. testing without adding confusing patches to other real issues.
Merge Request 72 is marked as draft because it will never be committed. There is no point in rebasing the MR when other commits are made. When required the branch can be recreated and force pushed.
| Comment | File | Size | Author |
|---|
Issue fork scheduler-3049585
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedThis patch checks if PHPlint fails the syntax for a continue statement inside try/catch.
This did not fail in the scheduler patch on 192 here but the identical code did fail on the moderation integration patch in #2 here
Comment #4
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedThis patch in #2 was not the same. This new patch more closely replicates the change in moderation integration patch in #2 here
So this should fail the phplint checks
Comment #6
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedOK. So the phplint syntax checking is more stringent at php7.1 than at php5.6.
That's good to know.
Comment #7
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedSome more work has been done on #3251399: Drupalci.yml filtering for testgroups: 'scheduler,scheduler_api' does not run all the required tests and here is a test using alexpott's patch #9 from that issue instead of my patch #4
Comment #8
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedCheck if DevelGenerateTest can be run without
@group legacyComment #10
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedCheck @group legacy on 8.x-1.x
Comment #13
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedComment #15
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedOK, lets abandon that idea.
Comment #21
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented