the attached patch is to port this module to drupal 7

CommentFileSizeAuthor
#18 sharedemail_pass_reset-d7_porting-1622924-18.patch7.39 KBron_s
#5 sharedemail_pass_reset-d7-porting-1622924-5.patch7.24 KBAlex Arnaud
#3 d7.patch2.83 KBlara_z
porttodrupal7.patch11.16 KBlara_z
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Qandeel’s picture

Qandeel CreditAttribution: Qandeel commented

Thanks for the patch... I will test it and after all test pass I will create 7.x release.

Qandeel’s picture

Qandeel CreditAttribution: Qandeel commented

patch reported an error

lara_z’s picture

lara_z CreditAttribution: lara_z commented
FileSize
d7.patch2.83 KB

the patch is attached

Qandeel’s picture

Qandeel CreditAttribution: Qandeel commented

Lara,

Ill test it and will get back to you soon

Thanks

Alex Arnaud’s picture

Alex Arnaud CreditAttribution: Alex Arnaud commented
Status: Active » Needs review
FileSize
sharedemail_pass_reset-d7-porting-1622924-5.patch7.24 KB

Hello,

Seems that the last patch has not been validated. Here is a new patch to get the module works with D7.
The patch has been done from existing 7.x-1.x branch.
Please test.

Qandeel’s picture

Qandeel CreditAttribution: Qandeel commented

Alex, thanks for the Patch, I will have it tested and will commit it

Shevchuk’s picture

Shevchuk CreditAttribution: Shevchuk commented

Is it committed yet?

P2790’s picture

P2790 CreditAttribution: P2790 commented
Issue summary: View changes

Any Updates?

Philo72’s picture

Philo72 CreditAttribution: Philo72 commented

Is there any updates to this?
I see the request to port to D7 was quite a while ago and a patch was made. Could this be done so We can test please.

Phil

sensei.by.design’s picture

sensei.by.design CreditAttribution: sensei.by.design commented

*bump*

ron_s’s picture

ron_s CreditAttribution: ron_s commented

Any update? Looks like the last 7.x-1.x commit was June 2012:
http://cgit.drupalcode.org/sharedemail_pass_reset/log/?h=7.x-1.x

Does not seem like the patch in #5 is included. Has anyone tested this?

  • Qandeel committed e475095 on 7.x-1.x 
    Issue #1622924 by alex-arnaud, qandeel: Porting to Drupal 7
Qandeel’s picture

Qandeel CreditAttribution: Qandeel as a volunteer commented

Guys,

Patch#5 has been patched and a 7.x-1.x branch has been updated; I have not tested yet so please spend some time and let me know if this is working fine.

Qandeel’s picture

Qandeel CreditAttribution: Qandeel as a volunteer commented
Version: 6.x-1.0 » 7.x-1.x-dev

  • Qandeel committed a402983 on 7.x-1.x authored by Alex Arnaud 
    Issue #1622924 by lara_z, Alex Arnaud, Qandeel, ron_s: Port to drupal 7
ron_s’s picture

ron_s CreditAttribution: ron_s commented

Thanks for posting this, @Qandeel.

We're successfully using a version of the previous port plus patch #5 on a site, so we'll compare the code to ours and see if there are any questions or issues.

ron_s’s picture

ron_s CreditAttribution: ron_s commented

@Qandeel, there seems to be a problem with the commit. When I git clone the 7.x-1.x branch, it's still the Drupal 6.x version. For example, the INSTALL.txt file is not correct:

http://cgit.drupalcode.org/sharedemail_pass_reset/tree/INSTALL.txt

ron_s’s picture

ron_s CreditAttribution: ron_s commented
FileSize
sharedemail_pass_reset-d7_porting-1622924-18.patch7.39 KB

I've created a patch that does the following:

1) Change references from Drupal 6 to 7 in INSTALL.txt
2) Reformat INSTALL.txt to fit 80 character standard
3) Update sharedemail_pass_reset.info to match project
4) Modify _validate error check to use one conditional
5) Reformat shared_pass_reset.module to Drupal coding standards

Let me know if any questions or feedback, thanks.