Early Bird Registration for DrupalCon Atlanta is now open! By registering during our Early Bird Registration window, you’ll save $100. This window ends on 19 January 2025 and will go by quickly, so don’t wait!Problem/Motivation
This is successor of 2930457
We need to update the patch to apply it on url_embed version 2.x
Steps to reproduce
Install clean version of Open Social
- enable social_embed module
- Create a post by visiting post/add/post and insert content: "Broken link example: http://example/idontexist and working Youtube embed example: https://youtu.be/ojafuCcUZzU"
- Go to homepage to confirm that post is correctly displayed
Proposed resolution
Update patch so it can be applied on url_embed version 2.x.
Remaining tasks
N/A
User interface changes
N/A
API changes
N/A
Data model changes
N/A
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | urlembed-non-embeddable-urls-2761187-opensocial-combined-21_2.x_2.patch | 9.07 KB | Anonymous (not verified) |
| #7 | urlembed-non-embeddable-urls-2761187-opensocial-combined-21_2.x_1_ckeditor5.patch | 9.07 KB | robertragas |
| #2 | urlembed-non-embeddable-urls-2761187-opensocial-combined-21_2.x_1.patch | 8.98 KB | zanvidmar |
Comments
Comment #2
zanvidmar CreditAttribution: zanvidmar commentedThis patch is combination of two patches (same like the previous version of patch for url_embed 1.x)
Patch 1
Add a caching layer for oembed data
https://www.drupal.org/files/issues/2020-10-13/url_embed-n2867668-25.patch
Patch 2
Non-embeddable links disappear in comments and post (where the patch is posted)
Improve how the module deals with non-embeddable URLs (issue that is referencing)
https://www.drupal.org/files/issues/2020-08-26/urlembed-non-embeddable-u...
We merge patch 1 and patch 2 and update the code so we can apply it on url_embed 2.x (2.0.0-alpha1)
Comment #3
zanvidmar CreditAttribution: zanvidmar commentedComment #4
zanvidmar CreditAttribution: zanvidmar commentedComment #5
zanvidmar CreditAttribution: zanvidmar commentedRelated PR: https://github.com/goalgorilla/open_social/pull/3519 with this patch included.
Comment #6
zanvidmar CreditAttribution: zanvidmar commentedComment #7
robertragas CreditAttribution: robertragas at Open Social commentedAdded a new version for this patch for when combined with the ckeditor5 for url-embed.
Comment #8
robertragas CreditAttribution: robertragas at Open Social commentedLanded in 11.11.0 (but not with the patch for ckeditor5, that story is still in progress, https://www.drupal.org/project/social/issues/3391286)
Comment #10
Anonymous (not verified) CreditAttribution: Anonymous commentedcomment to delete