I got this error using "drupal-check" command.

$ drupal-check /c/Bitnami/drupal-8.7.10-0/apps/drupal/htdocs/modules/contrib/social_auth_mailru
 2/7 [========>-------------------]  28%PHP Fatal error:  Declaration of Drupal\social_auth_mailru\MailruAuthManager::getExtraDetails($url) must be compatible with Drupal\social_auth\AuthManager\OAuth2Manager::getExtraDetails($method = 'GET', $domain = NULL) in C:\Bitnami\drupal-8.7.10-0\apps\drupal\htdocs\modules\contrib\social_auth_mailru\src\MailruAuthManager.php on line 15

In MailruAuthManager.php there is passed "$url" argument to getExtraDetails function, but in OAuth2Manager.php in social_auth module, function is built like this getExtraDetails($method = 'GET', $domain = NULL), so arguments are not matching.
When I've commented these lines, I got another error:

$ drupal-check /c/Bitnami/drupal-8.7.10-0/apps/drupal/htdocs/modules/contrib/social_auth_mailru
 2/7 [========>-------------------]  28%PHP Fatal error:  Class Drupal\social_auth_mailru\MailruAuthManager contains 2 abstract methods and must therefore be declared abstract or implement the remaining methods (Drupal\social_api\AuthManager\OAuth2ManagerInterface::getAuthorizationUrl, Drupal\social_auth\AuthManager\OAuth2ManagerInterface::requestEndPoint) in C:\Bitnami\drupal-8.7.10-0\apps\drupal\htdocs\modules\contrib\social_auth_mailru\src\MailruAuthManager.php on line 15

I think that social_auth_mailru is wrong implemented with social_auth module.

CommentFileSizeAuthor
#2 wrong_social_auth_implementation-3100349-2.patch6.25 KBAdev22

Issue fork social_auth_mailru-3100349

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

agrochal created an issue. See original summary.

Adev22’s picture

Adev22 CreditAttribution: Adev22 at Google Code-In commented
FileSize
wrong_social_auth_implementation-3100349-2.patch6.25 KB

here's the patch, I've fixed the wrong implementation and got this message 

drupal-check social_auth_mailru
 7/7 [============================] 100%


 [OK] No errors
Adev22’s picture

Adev22 CreditAttribution: Adev22 at Google Code-In commented
Status: Active » Needs review
agrochal’s picture

agrochal CreditAttribution: agrochal at Google Code-In commented
Status: Needs review » Needs work

drupal_set_message functions were replaced in this issue. Also, for the future, use dependency injection instead of calling it like this:
\Drupal\Core\Messenger\MessengerInterface::addMessage($this->t('Social Auth Mailru not configured properly. Contact site administrator.'), 'error');.
"drupal-check" for me gives no errors.

 drupal-check social_auth_mailru
 7/7 [============================] 100%


 [OK] No errors
gvso’s picture

gvso
Primary language Spanish
CreditAttribution: gvso at Google Code-In, Google Summer of Code commented
Title: Wrong social_auth implementation » Make Social Auth Mailru compatible with Social Auth 2.x
qzmenko’s picture

qzmenko
Primary language Russian
Location Novosibirsk
CreditAttribution: qzmenko as a volunteer and at Attico International commented
Title: Make Social Auth Mailru compatible with Social Auth 2.x » Make Social Auth Mailru compatible with Social Auth 3.x
Version: 8.x-2.x-dev » 3.0.x-dev

Social Auth 2.x is not supported already. We need to update this module for compatibility with Social Auth 3.x and for 4.x after that.

qzmenko opened merge request !1

  • qzmenko committed 65d38949 on 3.0.x 
    Issue #3100349: Make Social Auth Mailru compatible with Social Auth 3.x
qzmenko’s picture

qzmenko
Primary language Russian
Location Novosibirsk
CreditAttribution: qzmenko as a volunteer and at Attico International commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.