Hi,

First, thank you for creating such a great module.

While I was using this module to import content from Instagram, I've noticed that it only provide option to pull content from hashtag and user account id (integer only).

I recently created an account for Instagram API and it only allows me to pull from self since my "Client Status" is Sandbox mode. (I have to get approval from Instagram to get permission to pull content form public content like hashtag and other users. until then, sandbox mode only. content copy right policy.)

So I thought it might be useful to have sandbox mode option for Importing.

I attached patch for this. please review and let me know if it makes sense.

Cheers,
Ethan

CommentFileSizeAuthor
#10 social_content-instagram_sandbox_mode-2745209-10.patch2.15 KBethan.han777
#5 social_content-instagram_sandbox_mode-2745209-5.patch1.85 KBethan.han777
#2 social_content-instagram_sandbox_mode-2745209.patch2.21 KBethan.han777

Comments

ethan.han777 created an issue. See original summary.

ethan.han777’s picture

ethan.han777 commented
StatusFileSize
new social_content-instagram_sandbox_mode-2745209.patch2.21 KB
ethan.han777’s picture

ethan.han777 commented
Status: Active » Needs review
pere orga’s picture

pere orga
Primary language Catalan
commented
Status: Needs review » Needs work

Thanks for the patch.

I can't apply it:

$ git apply social_content-instagram_sandbox_mode-2745209.patch
error: social_content/modules/instagram/social_content_instagram.class.inc: No such file or directory

Looks like it has been created from a parent directory.

Please can you submit a patch for current 7.x-2.x-dev branch?

ethan.han777’s picture

ethan.han777 commented
StatusFileSize
new social_content-instagram_sandbox_mode-2745209-5.patch1.85 KB

oops I'm sorry about that.

ethan.han777’s picture

ethan.han777 commented
Status: Needs work » Needs review
pere orga’s picture

pere orga
Primary language Catalan
commented
Status: Needs review » Needs work

You forgot to add the import type.

ethan.han777’s picture

ethan.han777 commented

Thanks for reviewing the patch.
Could you be more specific on your comment above please?

pere orga’s picture

pere orga
Primary language Catalan
commented

This line is missing in patch #5:

   protected function getImportTypes() {
     return array(
+      'sandbox' => t('Pull from self'),
       'account' => t('Pull from account'),
ethan.han777’s picture

ethan.han777 commented
StatusFileSize
new social_content-instagram_sandbox_mode-2745209-10.patch2.15 KB

Thank you @Pere Orga
I added the missing import type in the new patch.

ethan.han777’s picture

ethan.han777 commented
Status: Needs work » Needs review
pere orga’s picture

pere orga
Primary language Catalan
commented
Status: Needs review » Postponed (maintainer needs more info)

Hi ethan.han777,

I just rechecked this, and now I don't see why this patch is needed. To run in sandbox mode you just need to use an Instagram sandbox app, and this is working.

Am I missing something?

Thanks