This is a starting point to make the toolbar tab available in the admin theme, configurable using the settings file and switched off by default. This does not include any kind of configuration form but instead uses a config setting.

This could easily be expanded upon to add a config form.

I have also added a fix for the admin toolbar tab icon (edit-icon) as this is currently not working.

CommentFileSizeAuthor
#9 2947903-make-admin-toolbars-tabs-configurable.patch3.61 KBandy_w
#4 2947903-4-make-admin-toolbar-tabs-configurable.patch1.59 KBandy_w
#2 2947903-2-make-admin-toolbar-tabs-configurable.patch1.3 KBandy_w

Comments

andywhale created an issue. See original summary.

andy_w’s picture

andy_w CreditAttribution: andy_w at Numiko commented
FileSize
2947903-2-make-admin-toolbar-tabs-configurable.patch1.3 KB

In order to make use of this patch we amend the settings.php file to include:

/**
 * Allow the toolbar tab to show in the admin theme.
 */
$config['toolbar.tab']['admin']['include'] = TRUE;
andy_w’s picture

andy_w CreditAttribution: andy_w at Numiko commented
Status: Needs work » Needs review
andy_w’s picture

andy_w CreditAttribution: andy_w at Numiko commented
FileSize
2947903-4-make-admin-toolbar-tabs-configurable.patch1.59 KB

Missed out the libraries file

karimbou’s picture

karimbou CreditAttribution: karimbou commented

I would like to know if it's normal in the block region for adminal theme there's not primary tabs and no secondary tabs like the seven theme for instance ? Aswell no block called status message ?
What i mean is per default I don't have any blocks at all

andy_w’s picture

andy_w CreditAttribution: andy_w at Numiko commented

Hi, is that comment related to this feature? Thanks.

daniel korte’s picture

daniel korte
he/him
Primary language English
Location Brooklyn, NY
CreditAttribution: daniel korte commented

I created a child issue to handle the pencil icon issue since that is unrelated to the primary bug report of this issue. Also, the patch here is missing the active tab CSS, it requires a specific folder structure since it references the core SVG icons, and it doesn’t check if the Contextual links module is disabled which is the cause of the pencil icon not showing up.
#3155956: Pencil icon is missing when the Contextual links module is disabled

daniel korte’s picture

daniel korte
he/him
Primary language English
Location Brooklyn, NY
CreditAttribution: daniel korte commented
Status: Needs review » Needs work

I think a config form is necessary here. Also, the icon issue has been fixed in the child issue so that code should be removed.

andy_w’s picture

andy_w CreditAttribution: andy_w at Numiko commented
FileSize
2947903-make-admin-toolbars-tabs-configurable.patch3.61 KB

Updated this to include a settings form and remove the already resolved styling.

  • Daniel Korte committed 9c6c20fd on 8.x-1.x authored by andy_w 
    Issue #2947903 by andy_w: Make tab toolbar available in admin theme...
daniel korte’s picture

daniel korte
he/him
Primary language English
Location Brooklyn, NY
CreditAttribution: daniel korte commented

Thanks, looks good. I removed the permission part and used the regular 'administer site configuration' permission here.

daniel korte’s picture

daniel korte
he/him
Primary language English
Location Brooklyn, NY
CreditAttribution: daniel korte commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.