Description is added to content and it is shown twice when using cck_fielgroup_tabs [#556004]

I have realized that if you set a description for a cck fielgroup tab, then when you are showing the fieldgroup tab, you get the description repeated because it was already added to the content.

I think there are two options, or not adding #description to #content or unsetting #description once it was added to #content,

On this patch I have unset the #description once it was added to the #content.

Also the css class for the tab description is the same than the description for any cck element shown in the fieldgroup tab so I have added a more specific class for this tab description.

Comment	File	Size	Author
#3	description_tabs_2.patch	982 bytes	jcmarco
	description_tabs.patch	970 bytes	jcmarco

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jcmarco CreditAttribution: jcmarco commented 21 August 2009 at 18:37

Status:

Active

» Needs review

Oops...

Comment #2

KoCo CreditAttribution: KoCo commented 22 August 2009 at 08:46

It works for me.

Maybe a suggestion, add both classes.
If someone styled the description class, it can be overridden with tabs-panel-description class.

thx,
Koen

Comment #3

jcmarco CreditAttribution: jcmarco commented 24 August 2009 at 11:12

File	Size
description_tabs_2.patch	982 bytes

@KoCo I added your suggestion because it allows back-compatibility and it also gives the option to override it.

Comment #4

nedjo

he/him/his

English

CreditAttribution: nedjo commented 25 August 2009 at 20:37

Status:

Needs review

» Fixed

Thanks for flagging the issue and suggesting a fix. I ended up just deleting the line that added the description, since it's no longer needed.

Comment #5

jcmarco CreditAttribution: jcmarco commented 26 August 2009 at 10:17

Umm! Now when editing/creating a node which content type has cck fieldgroup tabs, then the tab help text is lost! (the same with the fieldgroup description when it is shown)

In the case of CCK Fieldgroup Tabs now there is no way to show the cck fieldgroup description or help text into the tab or elsewhere.

I have sent a patch to the CCK Fieldgroup Tabs module to add fieldgroup help text and fieldgroup description into the tab content.

#559850: Fieldgroup help text and description are not shown in tabs with cck fieldgroup tabs style

Thank you for last upgrades to this modules

Comment #6

KoCo CreditAttribution: KoCo commented 31 August 2009 at 07:13

I confirm that with the latest stable release of "tabs 1.2" the description field is missing altogether.
Adding the lines by jcmarco fixes the description field.
Still have to test the other fieldgroup fields though.

Yet, the patch maybe better suited within cck fieldgroup tabs.