Fix pressflow incompatibility and standardize image object URL creation. [#877982]

Currently, this module breaks with newer releases of Pressflow because Pressflow altered the core file_create_url() function in the following commit:

http://bazaar.launchpad.net/~pressflow/pressflow/6/revision/74.1.1#inclu...

The attached path accomplished two things:

We send a full path including this files directory to file_create_url(). The allows the code to work with both stock Drupal and Pressflow.
We also now use the same code to generate $image[$tid]->url for both taxonomy term images and the default image.

Comment	File	Size	Author
	fix_pressflow_incompatibility.patch	1.39 KB	brianV

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

brianV CreditAttribution: brianV commented 9 August 2010 at 20:02

For more info, here is discussion of the changes to the file_create_url() function in Pressflow: https://bugs.launchpad.net/pressflow/+bug/597718

Comment #2

jdelaune CreditAttribution: jdelaune commented 12 August 2010 at 15:30

Status:

Needs review

» Reviewed & tested by the community

Thanks so much, was the going mad trying to figure out why it had stopped working!

Comment #3

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 22 August 2010 at 17:15

This patch should no longer be necessary thanks to #839282: Problems with shipped files and Drupal 6 file_create_url() behavior.

Comment #4

bibo CreditAttribution: bibo commented 15 November 2010 at 04:36

I got this problem after installing Pressflow, and have since been wasting hours to fix it. So glad I found this..

@Win Leers: Sorry, but how does that commit to the cdn-module fix this issue with taxonomy_image? :)

PS: the performance tips on your site are really great, thank you for them, and the module contributions!

Comment #5

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 15 November 2010 at 08:47

I think I tested back then with and without the patch by brianV after #839282: Problems with shipped files and Drupal 6 file_create_url() behavior and found it working in both cases. I'm not 100% sure anymore though. You should check again if that patch is still required. Maybe #3 was a brain fart :)

@bibo: glad you like my work :)

Comment #6

bibo CreditAttribution: bibo commented 19 November 2010 at 05:26

In any case, I can also confirm that this patch works (and saved my ass) :)

Comment #7

Beanjammin CreditAttribution: Beanjammin commented 21 January 2011 at 19:58

I also confirm that this patch worked for me. Thanks brianV!

Comment #8

naxoc CreditAttribution: naxoc commented 27 January 2011 at 16:57

This also does the trick for me :)

Comment #9

brianV CreditAttribution: brianV commented 3 February 2011 at 18:48

Marked #1043886: Module passes URL to getimagesize() instead of path as a duplicate of this one.

I can confirm that this patch is still needed with Pressflow 6.20.97 and Taxonomy Image 6.x-1.x-dev. Without this patch, Taxonomy Image is broken on Pressflow.

Comment #10

Jarek Foksa CreditAttribution: Jarek Foksa commented 6 February 2011 at 03:17

The patch also solves the issue for me. Tested with Pressflow 6.20.97 and Taxonomy Image 6.x-1.6.

Comment #11

j0nathan CreditAttribution: j0nathan commented 8 April 2011 at 21:35

Subscribing.

Comment #12

bibo CreditAttribution: bibo commented 7 July 2011 at 22:13

Status:	Reviewed & tested by the community	» Closed (fixed)
Issue tags:		+Pressflow

An interesting turn of events: file_create_url() was changed in the last Pressflow version! See https://bugs.launchpad.net/pressflow/+bug/790092

David Strauss wrote on 2011-06-01: #3
I've reverted the change to file_create_url() in Pressflow. Back to the drawing board for combined HTTP/HTTPS support for the same cached page...

Changed in pressflow:
status: Triaged → Fix Released

I noticed this after some taxonomy images broke down when a large site was updated to Pressflow 6.22. Our taxonomy_image was patched with the patch in this issue, and had been working for over 6 months. We replaced our patched version with the latest dev-version of taxonomy_image, and the images started working again.

This rather complicated doublefix => site-break means that the patch shouldn't be applied anywhere. Thus I'm closing this issue (maybe not my call, but anyone can re-open if needed..).