right now, if such a language is activated translation_overview does not create the correspondent table column. With this patch it does ;)

Comments

drewish’s picture

Status: Needs review » Needs work

definitely an improvement but it seems like we should also remove columns for languages that were removed when the module was disabled.

eMPee584’s picture

not my problem: i don't disable languages ;)

drewish’s picture

i can sympathize i don't disable translation_overview ;)

toemaz’s picture

My use case: I often enable/disable languages so the patch is for sure a good start, but as Drewish mentioned, not complete yet.

gagarine’s picture

Version: 6.x-2.x-dev » 7.x-2.x-dev

Same problem on 7.x. This is a problem when we try to enable this module with feature.

drtrueblue’s picture

For the sake of clarity, I want to be sure I understand the problem. Apologies for any redundancy.

In the event a language is added when translation overview is not enabled, and the module is later enabled, there is likely to be a conflict. Is that correct?
If so, can someone kindly confirm if the above patch applies to 7.x-2.x-dev?
If so, are there any plans to develop a patch for when a language is removed?
Lastly, it seems like the safest approach is to keep translation overview enabled whenever adding or deleting languages. Is that correct?

Thank you kindly.

JimDeLaHunt’s picture

Issue summary: View changes

I encountered the same problem with a Drupal 7.x (about 7.11) site from 2013, which I upgraded to 7.26 just now. I added a language, and Translation Overview did not add a corresponding column to the translation_overview_priority table. This led to PDO Exception errors when visiting the Translation Overview page, and when adding Article content.

The workaround of disabling, uninstalling, reinstalling, and reenabling Translation Overview worked for me.

In the introduction of this project's page, there is a recommendation that Drupal 7 users switch to Translation Management Tool instead. That module will be carried forward to Drupal 8, this one will not, apparently.

The current maintainers won't port this module to Drupal 8. The superseding Translation management (TMGMT) module was initiated with Drupal 7 and is already well ported to Drupal 8. We highly recommend it - already with Drupal 7.

stefan.r’s picture

If anyone wants to fix this, feel free to post a patch and I will look at it!