Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
keyword "connection" needs to be protected in sql query otherwise it causes sql errors (at least with MySQL 5.0.32 here). See attached patch...
Comment | File | Size | Author |
---|---|---|---|
#6 | tw-ticks.patch | 762 bytes | robertDouglass |
#3 | backticks.patch | 7.87 KB | robertDouglass |
#1 | connection.patch | 5.4 KB | mathieu |
connection.patch | 3.62 KB | mathieu |
Comments
Comment #1
mathieu CreditAttribution: mathieu commentedForgot a few, new patch.
Comment #2
robertDouglass CreditAttribution: robertDouglass commentedYes, and this has to be extended to code like this:
It can happen that the $tablename is also a reserved word. For example, I ran into:
SELECT MIN(blah) FROM grant;
Comment #3
robertDouglass CreditAttribution: robertDouglass commentedRerolled and added backticks for issue in #2. Agree that this is a critical issue.
Comment #4
mikeryanIt's just too gross to call tw_quote_column() on all those queries... I'm going to rename the field (say, to dbconnection), the code will be much cleaner.
Comment #5
mikeryanOK, I've committed fixes:
Thanks!
Comment #6
robertDouglass CreditAttribution: robertDouglass commentedHere's another place.
Comment #7
mikeryanCommitted, thanks!