Needs core_version_requirement: ^8 || ^9 to twitter_filters.info.yml to designate that the module is compatible with Drupal 9.

twitter_filters_before_patch

CommentFileSizeAuthor
#2 3129842-2.patch384 bytesankithashetty
twitter_filters_before_patch.png22.78 KBankithashetty

Comments

ankithashetty created an issue. See original summary.

ankithashetty’s picture

ankithashetty
Location Karnataka, India
CreditAttribution: ankithashetty as a volunteer and at Specbee commented
Status: Active » Needs review
StatusFileSize
new 3129842-2.patch384 bytes

Removed core: 8.x and added core_version_requirement: ^8 || ^9 in the twitter_filters.info.yml file to make it compatible with Drupal 9. Please review the below patch file.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: kristen pol at Hook 42 commented
Issue tags: +Drupal 9 compatibility
swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
CreditAttribution: swarad07 at Axelerant for Drupal India Association commented
Status: Needs review » Fixed

Thank you for your Patch, it was not applying cleanly though on 8.x-1.x branch.

git apply -v 3129842-2.patch
Checking patch twitter_filters.info.yml...
error: while searching for:

# Information added by Drupal.org packaging script on 2018-01-31
version: '8.x-1.0+2-dev'
core: '8.x'
project: 'twitter_filters'
datestamp: 1517375586

error: patch failed: twitter_filters.info.yml:6
error: twitter_filters.info.yml: patch does not apply

This issue is fixed in a recent update anyway, so closing this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.