Miscalculating subtotal excluding taxes line item [#1119762]

This module (v 6.13) is miscalculating the order subtotal line item. The total amount deducted from the gift certificate seems to be accurate, but the subtotal line item figures are off. The line item "Subtotal excluding taxes" shows the tax amount as a deduction (negative) and then the tax line item shows the tax amount (positive). see attached screen shot.

Comment	File	Size	Author
#5	uc_gift_certificate-fix_subtotal_before_tax_amount-1119762-5.patch	1.31 KB	dpintats
	Subtoatl-line-item.jpg	14.75 KB	kenheim

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

kenheim CreditAttribution: kenheim commented 12 April 2011 at 03:04

Bump! I've confirmed that this only occurs when the gift certificate is being applied.

Comment #2

kenheim CreditAttribution: kenheim commented 20 April 2011 at 17:42

Please help. Going live soon and need this issue resolved.

Comment #3

kenheim CreditAttribution: kenheim commented 20 April 2011 at 17:51

Priority:

Major

» Normal

Maybe this is related to http://drupal.org/node/393608 ??

Comment #4

kenheim CreditAttribution: kenheim commented 2 May 2011 at 19:52

Bump

Comment #5

dpintats CreditAttribution: dpintats commented 20 July 2012 at 09:36

Version:	6.x-1.3	» 6.x-1.x-dev
Status:	Active	» Needs review

File	Size
uc_gift_certificate-fix_subtotal_before_tax_amount-1119762-5.patch	1.31 KB

I was having the same issue you mentioned in your original post and was not able to find a patch that addressed it. I have created a patch that adjusts the subtotal before tax amount when reviewing the order, as well as the admin order overview page.

I was additionally having issues validating the amount on submitting the cart for review, so I also included the tax amount(s) to the order total on save so that the gift certificate will correctly deduct all amounts.

Btw, this is my first patch....please be gentle ;)

Comment #6

1kenthomas CreditAttribution: 1kenthomas commented 9 August 2012 at 23:03

Subscribing. Affects 2.0-dev as well, I'll see if the above patch can be used.

Comment #7

1kenthomas CreditAttribution: 1kenthomas commented 12 August 2012 at 06:39

I tried to use the patch code for -2.x-dev but failed to find a way, perhaps because I found two other issues which took all day to fix.

@dpintats: would be much appreciated if you could look at -2.x-dev and spin a solution. Glad to help as well, if you can clarify what's going on... though, alas, I get how things work and your solution works in -1.x, just not -2.x.