Problem/Motivation

Nav menu component does not use the link component to display links. Use this component instead of hard-coded links to be able to use all the features of link components, like target attributes.

Issue fork ui_suite_dsfr-3508919

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

goz created an issue. See original summary.

goz opened merge request !155

goz’s picture

goz commented
Status: Active » Needs review
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented

Hello,
i guess this proposal is tightly related to :
#3508926: Blank is not automatically setted for external link?

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented

hello,
the problem of using link component in nav_menu is that unwanted classes would be introduced in links.
we need to have an intermediate approach, i will post the code to cope with it in another MR.

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: Unassigned » just_like_good_vibes
Status: Needs review » Needs work

just_like_good_vibes opened merge request !158

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Title: Use component link in nav menu component » [1.1.0] nav menu : support attributes in links
just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented

MR 158! to review

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: just_like_good_vibes » pdureau
Status: Needs work » Needs review

just_like_good_vibes changed the visibility of the branch 3508919-use-component-link to hidden.

just_like_good_vibes’s picture

just_like_good_vibes
Location PARIS
commented
Assigned: pdureau » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.