Not all video style options are being applied

I can confirm this as well. Only happens for YouTube from what I can see. Vimeo autoplays just fine, YouTube not so much.

Same thing with me + "show related videos" to "off" not working.
I could make it all work changing line 198 in video_embed_field.handlers.inc to:
$settings_str = _video_embed_code_get_settings_str($settings);
not using urlencode() anymore : not sure it is safe to do that, but it fixed the problem...

Confirming!

changing line 198 in video_embed_field.handlers.inc to:
$settings_str = _video_embed_code_get_settings_str($settings);

works! ("related videos" to "off")
Thanks a lot!

oops

Here's the patch.

Thanks alot kevincrafts - patch is working! :)

Confirming RTBC. Please create a new stable release. This is completely broken currently!

I have tested the #7 and confirmed that it works well.

Great! :) Is there an active maintainer who many create a new stable release?

I currently maintain the 8.x branch, but have access to 7.x In the absence of the other maintainers, I might be able to look at testing these changes and cutting a new release.

Hello all.

That line was added due to #2537318 . So removing it will break that again. Could you try to provide a patch where both problems will disappear?

Thanks for all your work and interest.

These issues are definitely related. The patch I made in #2685721: Youtube autoplay does not work is almost identical to this one, except it will just encode the values instead. I'd recommend using the other patch, and closing this as a related/duplicate. I believe the patch also covers the original reason for the botched url encoding: #2537318: Percentage width/height breaks player

works: #2685721: Youtube autoplay does not work

@caw67 I confirm as well, works very well. RTBC +1

Sweet relief. RTBC +1

@kevincrafts good patch

I found another case where the URL was encoded incorrectly, this mostly impacted playlist URL's. Also when using playlist URL's the construction of the URL in that function was not correct. In that case the URL already had a "?" appended along with some parameters, the URL ended up having multiple '?' one appearing half way through the parameter list.

New Patch Attached.

Patch #19 worked perfectly for me. Thanks a lot !

And the status of this one seems to have been changed today: https://www.drupal.org/node/2682611

#19 works for me as well. I have this running on about 40 sites without known issues. Any way that we can get this committed? The suggested videos at the end of the YouTube videos are... let's just say... not professional... and don't blame my browser history either cause you may or may not be right! This patch fixes this amongst the others mentioned above.

Patch #19 works for me. Thanks!

I think patch #19 has two problems
- As @tyler.frankenstein pointed out in #15 it reintroduces the problem fixed in #2537318: Percentage width/height breaks player. % must be encoded in URLs.
- The patch removes a call to check_plain on $id. I agree @rbrandon is right there is a problem "In some cases the $id will include a list ID parameter for playlists." However I don't think we can remove check_plain entirely because that seems likely to introduce a security bug. Just a thought, it might be simpler to raise the list ID problem as a separate bug.

The patch in #2682611: Fix Video player youtube formatter settings not being applied seems like the correct one to me.

Here's the patch from #2682611: Fix Video player youtube formatter settings not being applied attached, and I've closed the other issue as a duplicate.

#25 tested successfully. +1 for RTBC.

#25 reviewed and tested.

• The bug reported in this issue is fixed.
• The bug from #2537318: Percentage width/height breaks player is still fixed.

There were 3 other reviewers in #2682611: Fix Video player youtube formatter settings not being applied so marking as RTBC. Upping the priority to Major because YouTube playback doesn't work properly, a regression compared with the previous release.

The issue from #19 with playlist URLs is still open, but it seems separate from the issue described here. It would be useful to create a new issue with title (so people can find it), repro scenario (the URL) and symptoms. This would facilitate a discussion of the correct secure patch.

Applied patch #25 instead of #19, 'show related videos' works as expected. Thanks everyone :)

Patch #25 works as expected, thanks.

same issue is present in d8 version. this patch needs to be ported there as well.

Patch in #25 works for me. +1

#25 worked for me as well

Will this be merged anytime soon? Happy to help in anyway I can. Would like to use this in production without having to bother w/ patch.

+1 for patch in #25. Thank you!

+1 for #25, thanks, tyler.frankenstein and kevincrafts!

5 years later and adding another +1 for patch in #25. Thanks, all!

Hi @all Thanks you for all your patches. The patch youtube_autoplay-2580459-25.patch applied successfully.

PS C:\xampp\htdocs\drupal\web\themes\custom\video_embed_field-2580459> git apply -v .\youtube_autoplay-2580459-25.patch
Checking patch video_embed_field.handlers.inc...
Checking patch video_embed_field.module...
Applied patch video_embed_field.handlers.inc cleanly.
Applied patch video_embed_field.module cleanly.

LGTM.

Creating an MR for helping out maintainer. Thanks tyler.frankenstein for the patch . Thanks