Problem/Motivation

There are no tests for this module!!!

Steps to reproduce

---

Proposed resolution

Build tests to cover:
- Drupal core views filters "string" and "combine"
- Filed/filter with and without relationship
- Filter operator
- And all possible options that come with this filter.

Remaining tasks

- Functional Javascript [must]
- Functional (optional - maybe follow-up issue)
- Kernel (optional - maybe follow-up issue)

User interface changes

---

API changes

---

Data model changes

---

Issue fork views_autocomplete_filters-3428016

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vasike created an issue. See original summary.

vasike opened merge request !18

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike as a volunteer commented
Status: Active » Needs review
Related issues: +#3259438: Not working with contextual filters

MR available

Implement ViewsAutocompleteFiltersTest Functional Javascript tests,
trying to cover all (usual) possible cases, except "Allow Contextual filters to apply to this filter" option,
As I'm not sure how to replicate the solution from https://www.drupal.org/project/views_autocomplete_filters/issues/3259438.

No Kernel or Functional tests ... maybe in a follow-up.

  • vasike committed c6802465 on 2.0.x 
    Issue #3428016 by vasike: Add tests - Implement...
vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike as a volunteer commented
Status: Needs review » Fixed

MR passed and merged
+ Added follow-up issue https://www.drupal.org/project/views_autocomplete_filters/issues/3430426

I think we can close it.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike as a volunteer commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.