PDF Table: rows overlap on pages 2,3... if a row takes more than one line [#2363889]

Comment	File	Size	Author
#14	Table_rows_overlap-2363889-14.patch	1.58 KB	vegansupreme
#11	Table_rows_overlap-2363889-11.patch	2.35 KB	vegansupreme
#10	Table_rows_overlap-2363889-10.patch	2.35 KB	vegansupreme
	net_sales_for_category.pdf	13.43 KB	calmforce

Comment #1

calmforce CreditAttribution: calmforce commented 27 October 2014 at 14:27

Issue summary:

View changes

Log in or register to post comments

Comment #2

vegansupreme CreditAttribution: vegansupreme commented 27 October 2014 at 14:40

Hmm, maybe we need something like Minimal Space, for tables.

This issue references minimal space, but isn't the original issue that created it.
#2344289: Minimal Space setting doesn't work
If we add this feature to table display, it shouldn't have an effect on existing users, because that setting doesn't currently exist.

If you want to make a patch, I'll do what I can to get it committed ASAP, but I don't know when I'll be able to attempt a patch myself. I'll do my best to answer any questions.

Log in or register to post comments

Comment #3

calmforce CreditAttribution: calmforce commented 27 October 2014 at 15:07

@vegansupreme: I am not sure how Minimal Space can help here. There is row_height setting already. I believe the bug is in drawTable() function, somewhere between the lines 726 and 776. The problem demonstrates itself by printing the second row always just next to the first row on every page except the first one, assuming that the first row is always just one line. So if we give "Minimal Space" to each row, the second one may still overlap with the first one - if the first one takes several lines.

Log in or register to post comments

Comment #4

vegansupreme CreditAttribution: vegansupreme commented 27 October 2014 at 15:49

Oh I see. I thought the problem was the last line was continuing onto the next page, but now I see what you mean. Line 1 doesn't have correct height, after the first page.
I'll try duplicating this problem as soon as I can.

Log in or register to post comments

Comment #5

richH CreditAttribution: richH commented 18 January 2015 at 17:22

Hi

any news on this? This is a show stopper for me and it would be great to have a fix for it.

Thanks
RIch

Log in or register to post comments

Comment #6

vegansupreme CreditAttribution: vegansupreme commented 19 January 2015 at 13:36

I'm looking into this. As a not so great workaround, putting the longest field last seems to prevent this bug. Looks like Views PDF calculates the height of the row based on the maximum height of all the fields, except when starting a new page—then it only uses the last field in the row, not the tallest.

Log in or register to post comments

Comment #7

mithungupta CreditAttribution: mithungupta commented 9 February 2015 at 11:28

putting the longest field last can prevent this bug if there is only one longest field but if there is more than one than again it creates problem, that's why it seems stopper for me. is there any update which can help me......

Log in or register to post comments

Comment #8

vegansupreme CreditAttribution: vegansupreme commented 9 February 2015 at 14:21

I've already put a few hours into this, but haven't gotten much closer to a solution. I'll take another crack at it today.

Log in or register to post comments

Comment #9

vegansupreme CreditAttribution: vegansupreme commented 9 February 2015 at 14:21

Priority:

Normal

» Major

Log in or register to post comments

Comment #10

vegansupreme CreditAttribution: vegansupreme commented 11 February 2015 at 19:21

Status:

Active

» Needs review

File	Size
Table_rows_overlap-2363889-10.patch	2.35 KB

This is the best I've got so far. It's not perfect, but it can help a bit. I noticed PDF tables weren't respecting page margins for the first page, but subsequent pages were respecting top margin at least. This fixes the margin behavior, and also helps with row overlap—as long as your margins are not very small. If you're still getting overlap with this patch, try increasing top and bottom margins until you don't get overlap anymore. Hopefully this will be a workable solution for anyone having this problem.

Log in or register to post comments

Comment #11

vegansupreme CreditAttribution: vegansupreme commented 11 February 2015 at 19:26

File	Size
Table_rows_overlap-2363889-11.patch	2.35 KB

1 file was hidden/shown/deleted

File	Size
Table_rows_overlap-2363889-10.patch	2.35 KB

Super small CS fix.

Log in or register to post comments

Comment #12

mithungupta CreditAttribution: mithungupta commented 12 February 2015 at 08:23

@vegansupreme: applied "Table_rows_overlap-2363889-11.patch", increased top and bottom margins. still getting row overlap.

i cant understand the fun behind these lines of codes...
@@ -25,7 +25,6 @@ class views_pdf_plugin_style_table extends views_plugin_style {
return $output;
}

-
/**
* Option definitions
*/