Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
All the edit linkks of the D7 version still point to the structure of D6, thus making the module unuable:
As of now: /admin/build/views/ <---That's D6!!
How it should be: /admin/structure/views <---This is D7
Not sure how this even made it into a release version.
Comment | File | Size | Author |
---|---|---|---|
#5 | views_ui_basic-1553146-4-link_fixes.patch | 4.18 KB | Simon Georges |
#3 | views_ui_basic-link_fixes-1553146-5934190.patch | 4.29 KB | 3rdLOF |
Comments
Comment #1
3rdLOF CreditAttribution: 3rdLOF commentedActually, it is even worst. I presume very few people are using this in D7 because the disparity in links cannot be explained. The way the links are build in this module for D7 are like this:
line 394 of views_ui_basic.module:
return 'No Views configured. Please ' . l('select the views', 'admin/build/views/views_ui_basic') . ' you wish to use.';
it should be:
return 'No Views configured. Please ' . l('select the views', 'admin/structure/views/views_ui_basic') . ' you wish to use.';
line 38 of views_ui_basic.admin.inc is:
'#title' => $view_key . ' [' . l(t('edit view'), "admin/build/views/edit/$view_key", array('attributes' => array('target' => '_blank'))) . ']',
it should be, with the edit parameter AFTER the view name
'#title' => $view_key . ' [' . l(t('edit view'), "admin/structure/views/view/$view_key/edit/", array('attributes' => array('target' => '_blank'))) . ']',
The permissions links is also wrong:
line 38 of views_ui_basic.admin.inc is:
$form["#prefix"] = '<p>' . t('Use this form to define which Views may be editable by users with the "' . l('edit views basic settings', 'admin/user/permissions').'" permission.') . '</p><p>' . t('Please note that the "override" button will be hidden, so if your view uses multiple displays, you will probably want to modify the header/footer/empty text/title/etc fields to be "overriden," otherwise it will update the default display when the user goes in and modifies them.') . '</p>';
it should be
$form["#prefix"] = '<p>' . t('Use this form to define which Views may be editable by users with the "' . l('edit views basic settings', 'admin/people/permissions').'" permission.') . '</p><p>' . t('Please note that the "override" button will be hidden, so if your view uses multiple displays, you will probably want to modify the header/footer/empty text/title/etc fields to be "overriden," otherwise it will update the default display when the user goes in and modifies them.') . '</p>';
Furthermore:
A) The module does not check for which Views are enable and lists all views, even disabled ones.
B) The link generated bia the Content -> Edits Views tab is also wrong and when using the default Drupal 7 admin theme "Seven", the links throw a catatrophic crash:
"Fatal error: Cannot unset string offsets in /var/www/drupal/sites/xxxxx.com/themes/seven/template.php on line 32"
D) The Update system and Drush still track the DEV version as correct even though is not even listed and does not track the release version at all.
Comment #2
Jonah Ellison CreditAttribution: Jonah Ellison commentedHi kannary100,
Thanks for pointing these out. You can help by attaching a patch file (http://drupal.org/node/1319154)
Comment #3
3rdLOF CreditAttribution: 3rdLOF commentedComment #4
Simon Georges CreditAttribution: Simon Georges commentedActually, the link to the main page is still wrong, it should be
admin/structure/views/views_ui_basic
instead ofadmin/structure/views/view/views_ui_basic
(in your patch).Otherwise, from what I can test, the patch applies perfectly and fixes the links. Thanks a lot! This should be committed as soon as possible to make the module usable in D7.
Comment #5
Simon Georges CreditAttribution: Simon Georges commentedNew patch, all credit goes to kannary100.
Comment #6
Simon Georges CreditAttribution: Simon Georges commentedThe main concern of the issue, covered by the patches, has been committed. Let's handle the rest in other issues. Thanks!