I'm getting this error on admin/content/views_ui_basic:

Notice: Undefined index: title in views_ui_basic_list_page() (line 343 of /Users/chellman/Sites/paxchristi/paxchristi.net/sites/all/modules/views_ui_basic/views_ui_basic.module).

The offending line is:

$displayname = $views_display->display_options['title'];

Immediately following that is an if !empty($displayname), so the two of these together make me think we should test for this key before trying to set it. Either that, or forget about it. I'm not sure what the difference is between these two things in this context:

$views_display->display_title (always set, it seems)

vs

$views_display->display_options['title'] (no always set)

Wanted to check on this before submitting a patch.

CommentFileSizeAuthor
#7 Untitled-1.jpg81.8 KBvibrasphere
#2 undefined_index_title_1995896.patch653 bytesundertext
#1 Master: Pager options.png32.76 KBMrPaulDriver
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MrPaulDriver’s picture

MrPaulDriver CreditAttribution: MrPaulDriver commented
FileSize
Master: Pager options.png32.76 KB

I am seeing the same error at admin/content/views_ui_basic

I only have pager options enabled. The offset value is displayed and is editable but no other pager controls are available.

See screenshot

undertext’s picture

undertext CreditAttribution: undertext commented
FileSize
undefined_index_title_1995896.patch653 bytes

Just need this patch.

Simon Georges’s picture

Simon Georges CreditAttribution: Simon Georges commented
Status: Active » Needs review

@undertext, did you only make the patch, or did you tested it and can confirm this is indeed the right solution? (just so I know I can go ahead and commit it).

undertext’s picture

undertext CreditAttribution: undertext commented

I'm here again.
display_options['title'] is used by views to set the title of the page, and the key 'title' will be in array if you are creating a Page Display, or a Block Display, or a Feed Display. Otherwise key 'title' won't be in display options array.

You can look into 'build_display_options' function in 'views\plugins\views_wizard\views_ui_base_views_wizard.class.php'.

Simon Georges’s picture

Simon Georges CreditAttribution: Simon Georges commented
Status: Needs review » Fixed

Ok, committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

vibrasphere’s picture

vibrasphere CreditAttribution: vibrasphere commented
Issue summary: View changes
Status: Closed (fixed) » Needs work
FileSize
Untitled-1.jpg81.8 KB

How is this committed and fixed if I just installed the module and getting this error?
a

Drupal 7.26
views_ui_basic 7.x-1.2 (I don't see no dev version)

Simon Georges’s picture

Simon Georges CreditAttribution: Simon Georges commented
Status: Needs work » Fixed

Hi, I just made the -dev version available to download. For your information, I'm just waiting for some people to test the -dev version, but I plan to release the 7.x-1.3 (which includes this fix) as soon as possible.

vibrasphere’s picture

vibrasphere CreditAttribution: vibrasphere commented

Also why editing it opens in the website's theme interface and not in the administration theme? Also that error appears in the Edit views page when selecting Page in settings, if selecting Master, the error appears inside the editable Header or Footer page.

Simon Georges’s picture

Simon Georges CreditAttribution: Simon Georges commented

The fact that it's not the administration theme should have been fixed in the -dev version as well. Please test this version and give me some feedback, if it's all good, I may release it sooner.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

cmseasy’s picture

cmseasy CreditAttribution: cmseasy commented

Bumped into this Undefined index issue, fixed it with de dev version