If I leave show when empty unchecked, the tab of the empty view is still shown. Clicking to it makes the whole tabset disappear! - #734070: Empty views causes tabs to disappear

Isn't the behavior supposed to be, if show when empty is unchecked, the empty tab is not shown?

Thanks for making this great module.

CommentFileSizeAuthor
#15 734380_3.patch863 bytessmokris
#10 734380_2.patch2.81 KBramlev
#8 734380_1.patch2.06 KBramlev
#7 734380.patch1.3 KBramlev
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

subscribe

4kant’s picture

4kant CreditAttribution: 4kant commented

subscribe

mzwyssig’s picture

mzwyssig CreditAttribution: mzwyssig commented

Subscribe.

mzwyssig’s picture

mzwyssig CreditAttribution: mzwyssig commented
Priority: Normal » Major
vlooivlerke’s picture

vlooivlerke CreditAttribution: vlooivlerke commented

This is a serious problem. You are also unable to hide a normal view tab if the view is empty. There are plenty treads trying to solve this issue but none was successful.

I thought this module was a solution but now it has the same problem as views tabs.
It shows if the view is empty. Why would you want a button that point to nothing?

iNade’s picture

iNade CreditAttribution: iNade commented

Subscribing

ramlev’s picture

ramlev CreditAttribution: ramlev commented
FileSize
734380.patch1.3 KB

I have done a patch, which seems to fix the issue in the 6.x-1.0-beta6 version.

Dont have done the check in $show , since i believe that the author have another thought on this variable.

Please lemme know if it's all good

ramlev’s picture

ramlev CreditAttribution: ramlev commented
FileSize
734380_1.patch2.06 KB

A new and updated patch is attached, a minor bug is fixed.

It now works if your view contains any arguments.

vlooivlerke’s picture

vlooivlerke CreditAttribution: vlooivlerke commented

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 80 bytes) in /sites/all/modules/views/includes/base.inc on line 88

I get this error message when I patch the module and visit a views display tabs website.

My memory limit is 128m.

ramlev’s picture

ramlev CreditAttribution: ramlev commented
FileSize
734380_2.patch2.81 KB

I have added a new patch, which is removing the view variable after testing if the view tab is containing any data, this should free up a lot of memory.

You should replace the old patch with this one

vlooivlerke’s picture

vlooivlerke CreditAttribution: vlooivlerke commented

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 78 bytes) in /sites/all/modules/views/plugins/views_plugin_display.inc on line 223

and

Fatal error: Allowed memory size of 134217728 bytes exhausted (tried to allocate 76 bytes) in /home/wiki/public_html/sites/all/modules/views/includes/base.inc on line 100

still some errors.

vlooivlerke’s picture

vlooivlerke CreditAttribution: vlooivlerke commented

ok I increased my memory limit to 256M but still get the same errors, it even use more memory.

http://utopiaclivias.co.za/ here is a link to show you that my tab menus are not that extensive to use so much memory.

Or I must be patching the wrong version.

udane’s picture

udane CreditAttribution: udane commented

I have the same problem. Is there a solution?
Thanks.

mindaugasd’s picture

mindaugasd CreditAttribution: mindaugasd commented

sub

smokris’s picture

smokris
Location Athens, Ohio, USA
CreditAttribution: smokris commented
Title: Turning off show when empty does not work » Turning off "Show when empty" still shows other tabs with no results
Status: Active » Needs review
FileSize
734380_3.patch863 bytes

Revised patch attached, which applies cleanly to 6.x-1.0-beta6. Works for me with views-6.x-2.16 (no memory issues as reported above).

crash98’s picture

crash98 CreditAttribution: crash98 commented

#15 also works for me with Views 6.x-2.16. Thx.