Implement hook_user_delete() to delete submissions when user account is deleted [#3171670]

Problem/Motivation

When a user deletes their account any Webform submissions they created while logged in will remain on the site, still tied to their now deleted user account.

Proposed resolution

Implement hook_user_delete() and provide an option to delete the user's submissions.

Remaining tasks

Implement hook_user_delete() to delete the user's submissions.
Provide an option on whether the deletion happens; some sites may wish to retain this data.

User interface changes

New global option to control whether the submissions are deleted.

API changes

n/a

Data model changes

n/a

Comment	File	Size	Author
#6	3171670-6.patch	2.72 KB	guilhermevp
#6	7.x-4.x: PHP 7.4 & MySQL 5.7, D7.78 22 pass PHP 7.3 & MySQL 5.7, D7.78 22 pass
#6	delete_user.png	10.9 KB	guilhermevp

Issue fork webform-3171670

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3171670-implement-hookuserdelete-to changes, plain diff MR !18
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

17 September 2020 at 20:09

DamienMcKenna created an issue. See original summary.

Comment #2

guilhermevp CreditAttribution: guilhermevp at CI&T commented 12 February 2021 at 18:08

I was implementing the requested solution when I notice that drupal 7 has an built in option for deletion of all data upon removal of user. Don't know if I understood the request correctly, but seems to me an unecessary feature.

Comment #3

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 12 February 2021 at 18:21

That option in core deletes nodes, but I don't see any integration in Webform for deleting submission data, hence the request.

Comment #4

guilhermevp CreditAttribution: guilhermevp at CI&T commented 17 February 2021 at 16:46

The only way it seems possibile to remove all submited data from removed user, is to add an indentifier in the webform_submitted_data table, but it seems to be a intrusive change. Is it correct?

Comment #5

guilhermevp CreditAttribution: guilhermevp at CI&T commented 18 February 2021 at 17:28

Assigned:

Unassigned

» guilhermevp

Comment #6

guilhermevp CreditAttribution: guilhermevp at CI&T commented 18 February 2021 at 18:11

File	Size
delete_user.png	10.9 KB
3171670-6.patch	2.72 KB
7.x-4.x: PHP 7.4 & MySQL 5.7, D7.78 22 pass PHP 7.3 & MySQL 5.7, D7.78 22 pass

So, if I understood you correctly you want a toggleable option to delete all user data when said user is deleted.
So I implemented a menu option under advanced configurations of webform. When the option is checked everything from webform_submissions and weboform_submitted_data is deleted.

Comment #7

guilhermevp CreditAttribution: guilhermevp at CI&T commented 18 February 2021 at 18:11

Assigned:	guilhermevp	» Unassigned
Status:	Active	» Needs review

Comment #8

Nishat Ahmad CreditAttribution: Nishat Ahmad as a volunteer and at Douce Infotech Pvt. Ltd. commented 19 February 2021 at 16:15

I have check #6 and It's working fine for me.

Comment #9

Liam Morland

English

Ontario, CA 🇨🇦

CreditAttribution: Liam Morland at University of Waterloo commented 17 March 2021 at 15:00

Status:

Needs review

» Needs work

Thanks for the patch.

I think webform_user_delete() should always exist and have the check for variable webform_delete_user_data inside the function. Otherwise, changing the variable will require a cache clear for the hook to become effective.

Please post the patch in an issue fork. Let me know if you need any help with this.