Module Installation error when on PostgreSQL [#2236295]

Hello, great module.
I found an issue trying to enable the module on D7 with PostgreSQL. Te problem is that the word "end" used as column name in the table webform_scheduler is a reserved word in PostgreSQL so the module cannot be enable.

I changed the names to "begin_date" and "end_date" and made some minor changes to the code (on load/save data to DB) to get it working.

Comment	File	Size	Author
#1	reserved_word_error_postgresql-2236295-1.patch	3.54 KB	mscalone

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mscalone CreditAttribution: mscalone commented 8 April 2014 at 21:09

File	Size
reserved_word_error_postgresql-2236295-1.patch	3.54 KB

Comment #2

mscalone CreditAttribution: mscalone commented 9 April 2014 at 13:10

Title:	Module Instalation error when on PostgreSQL	» Module Installation error when on PostgreSQL
Issue summary:	View changes

Comment #3

mscalone CreditAttribution: mscalone commented 9 April 2014 at 13:10

Issue summary:

View changes

Comment #4

10 April 2014 at 21:51

Commit 930fc25 on 7.x-1.x authored by mscalone, committed by dwieeb:

Issue #2236295 by mscalone: Module Installation error when on PostgreSQL

Comment #5

dwieeb CreditAttribution: dwieeb commented 10 April 2014 at 21:53

Status:

Needs review

» Fixed

Thanks for the patch! I applied it and made beta8 for download now.

Comment #6

mscalone CreditAttribution: mscalone commented 21 April 2014 at 15:28

you are welcome!

After made the patch I thought it would be nice to add one more feature: the possibility to add some text message to the webform after closed. Maybe add another option to the "Access restriction method" configuration, something like "Allow access to the page, hide the webform and show following message" with a textarea to set that text.